Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace maptools and rgdal #71

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Replace maptools and rgdal #71

merged 4 commits into from
Jun 9, 2023

Conversation

pdil
Copy link
Owner

@pdil pdil commented Jun 8, 2023 •
edited

  • Replaced maptools::elide with sp::elide
  • Replaced rgdal with sf as sp now depends on it
  • This should also resolve CRAN warnings/errors related to missing functions (e.g. maptools::elide)

See https://r-spatial.org/r/2023/04/10/evolution3.html for more information

fixes #57
fixes #70
closes #68

@pdil pdil added the tech Technical issues and pull requests not directly related to usmap functionality label Jun 8, 2023
@pdil pdil self-assigned this Jun 8, 2023
@pdil pdil force-pushed the bugfix/replace-maptools-and-rgdal branch 2 times, most recently from fdc5093 to d0a273d Compare June 8, 2023 21:57
@pdil pdil force-pushed the bugfix/replace-maptools-and-rgdal branch from d0a273d to c9e1373 Compare June 8, 2023 22:08
@pdil pdil merged commit 132175b into master Jun 9, 2023
8 checks passed
@pdil pdil deleted the bugfix/replace-maptools-and-rgdal branch June 9, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pdil pdil

Labels
tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability to absence of retiring r-spatial packages maptools retiring soon
1 participant
@pdil