Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pbs_installer interface (build_dir) for auto-install best match strategy #2973

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

o-moe
Copy link
Contributor

@o-moe o-moe commented Jun 25, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fix for new pbs_installer interface regarding build_dir and best match auto-install strategy for pdm-use. Basically the same fix as for pdm python install --list recently.

@o-moe
Copy link
Contributor Author

o-moe commented Jun 25, 2024

@frostming shall new news entry be changed to reflect this PR #? Currently I used my original feature request issue #

@o-moe
Copy link
Contributor Author

o-moe commented Jun 25, 2024

This "quick fix" makes me wonder if pdm python install --list should better share the same implementation to get the candidates as the best match auto-install functionality (which would filter additionally). So that in the future - if pbs_installer changes again, all CLI commands benefit from a fix

@o-moe o-moe changed the title Fix/pdm lock fix: pbs_installer interface (build_dir) for auto-install best match strategy Jun 25, 2024
@frostming
Copy link
Collaborator

This "quick fix" makes me wonder if pdm python install --list should better share the same implementation to get the candidates as the best match auto-install functionality (which would filter additionally). So that in the future - if pbs_installer changes again, all CLI commands benefit from a fix

Sure, please move it to utils module as it does not depend on self.

Also please update pdm.lock and set the minimum version of pbs_installer to 2024.4.18

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming merged commit fb173be into pdm-project:main Jun 26, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants