#5 Add module BasicPlayer. #6
Conversation
I added the BasicPlayer module with the sources downloaded from http://www.javazoom.net/jlgui/api.html. A direct link for the zip file is: http://www.javazoom.net/jlgui/sources/basicplayer3.0.zip Please note the following modifications to the BasicPlayer source code were made while adding them to this module: 1. Relocated src/javazoom to src/main/java/javazoom, and srctest/javazoom to src/test/java/javazoom. This was done to adhere to the standard maven file structure layout. 2. Replaced dependency on commons-logging-api with dependency on slf4j-api. This was done because commons-logging-api is not a valid OSGi bundle while slf4j-api is. This required changing BasicPlayer.java lines 48, 49, and 74 to use the slf4j api instead of commons logging. Additional modifications to existing project code: 1. Updated project aggregate pom to include the basicplayer module. 2. Added <Export-Package>javazoom.spi</Export-Package> to the maven-bundle-plugin configuration instructions in the mp3spi module. BasicPlayer imports this package. 3. Updated README.adoc with information pertaining to the BasicPlayer module.
| @@ -50,6 +50,7 @@ | |||
| <configuration> | |||
| <instructions> | |||
| <SPI-Provider>javax.sound.sampled.AudioSystem</SPI-Provider> | |||
| <Export-Package>javazoom.spi</Export-Package> | |||
There was a problem hiding this comment.
I don't understand the need for changing this - currently released version already exports the package - javazoom.spi;version="1.9.5"
|
Thank you for pointing that out. I originally made that change because of a warning in my IDE. I should have confirmed this warning prior to making that change. I removed that from the pom in mp3spi. I also updated the version of the dependency in basicplayer to use the current version of the tritonus-share module. |
|
Thank you @axiopisty! I merged the PR, however I will be offline for next two weeks, so it might take a while to have this in Central. |
|
Okay. I'll look for them in Central then. Thank you. On Mon, Jun 27, 2016 at 12:33 AM, Patrik Duditš notifications@github.com
|
|
Oh, I just realized that deployment to central failed a week ago., I re-uploaded everything now and basicplayer is on its way to Central. |
I added the BasicPlayer module with the sources downloaded from http://www.javazoom.net/jlgui/api.html.
A direct link for the zip file is: http://www.javazoom.net/jlgui/sources/basicplayer3.0.zip
Please note the following modifications to the BasicPlayer source code were made while adding them to this module:
1. Relocated src/javazoom to src/main/java/javazoom, and srctest/javazoom to src/test/java/javazoom. This was done to adhere to the standard maven file structure layout.
2. Replaced dependency on commons-logging-api with dependency on slf4j-api. This was done because commons-logging-api is not a valid OSGi bundle while slf4j-api is. This required changing BasicPlayer.java lines 48, 49, and 74 to use the slf4j api instead of commons logging.
Additional modifications to existing project code:
1. Updated project aggregate pom to include the basicplayer module.
2. Added javazoom.spi to the maven-bundle-plugin configuration instructions in the mp3spi module. BasicPlayer imports this package.
3. Updated README.adoc with information pertaining to the BasicPlayer module.