Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5 Add module BasicPlayer. #6

Merged
merged 3 commits into from
Jun 27, 2016
Merged

Commits on Jun 18, 2016

  1. pdudits#5 Add module BasicPlayer.

    I added the BasicPlayer module with the sources downloaded from http://www.javazoom.net/jlgui/api.html.
    
    A direct link for the zip file is: http://www.javazoom.net/jlgui/sources/basicplayer3.0.zip
    
    Please note the following modifications to the BasicPlayer source code were made while adding them to this module:
        1. Relocated src/javazoom to src/main/java/javazoom, and srctest/javazoom to src/test/java/javazoom. This was done to adhere to the standard maven file structure layout.
        2. Replaced dependency on commons-logging-api with dependency on slf4j-api. This was done because commons-logging-api is not a valid OSGi bundle while slf4j-api is. This required  changing BasicPlayer.java lines 48, 49, and 74 to use the slf4j api instead of commons logging.
    
    Additional modifications to existing project code:
        1. Updated project aggregate pom to include the basicplayer module.
        2. Added <Export-Package>javazoom.spi</Export-Package> to the maven-bundle-plugin configuration instructions in the mp3spi module. BasicPlayer imports this package.
        3. Updated README.adoc with information pertaining to the BasicPlayer module.
    axiopisty committed Jun 18, 2016
    Configuration menu
    Copy the full SHA
    8fca933 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2016

  1. Removed unnecessary Export-Package configuration from the maven-bundl…

    …e-plugin in mp3spi module.
    axiopisty committed Jun 27, 2016
    Configuration menu
    Copy the full SHA
    d388122 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    411ddc5 View commit details
    Browse the repository at this point in the history