[fix] errors require and formatting

pdvend · Jun 30, 2017 · 9a27436 · 9a27436
1 parent 471f721
commit 9a27436
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/lib/br_invoices_pdf.rb b/lib/br_invoices_pdf.rb
@@ -3,20 +3,25 @@
 
 require 'br_invoices_pdf/version'
 require 'br_invoices_pdf/generator'
+require 'br_invoices_pdf/errors/invalid_document_type'
 
 module BrInvoicesPdf
   @generators = {}
 
   module_function
 
-  def generate(type, xml, options)
+  def generate(type, xml, options = {})
     generator = @generators[type]
     raise(Errors::InvalidDocumentType, type) unless generator
     generator.generate(xml, options)
   end
 
   def register(type, renderer, parser)
-    @generators[type] = Generator.new(renderer, parser)
+    @generators[type.to_sym] = Generator.new(renderer, parser)
+  end
+
+  def supported_document_types
+    @generators.keys
   end
 end
 

diff --git a/lib/br_invoices_pdf/errors/invalid_document_type.rb b/lib/br_invoices_pdf/errors/invalid_document_type.rb
@@ -1,9 +1,12 @@
 module BrInvoicesPdf
-  class InvalidDocumentType < StandardError
-    attr_reader :type
+  module Errors
+    class InvalidDocumentType < StandardError
+      attr_reader :type
 
-    def initialize(type)
-      @type = type
+      def initialize(type)
+        super("`#{type.inspect}` is not supported. Must be one of #{BrInvoicesPdf.supported_document_types}")
+        @type = type
+      end
     end
   end
 end