-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action fails when inbound and existing excluded assets differ in state #520
Comments
Thanks. Related to #163 (comment) BTW, I recommend you to remove the - name: Install and Render
run: |
npm install
node -e "require('spec-up')({ nowatch: true })"
+ rm -rf node_modules
- name: Deploy
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./
- exclude_assets: '.github,node_modules/**'
force_orphan: true |
We already have |
Ah, I just saw the |
@peaceiris so are you saying I can/should still use manual removal via node commands to exclude files from the runs, or that it's safe to against use the built-in exclude feature? |
I still recommend my suggestion for fast deployment. The bug was that you mentioned in #520 (comment). Dotfiles on a root directory had been ignored in the copy operation. |
Describe the bug
When using the excluded asset option, the Action fails if one of the inbound assets differs from the existing set.
To Reproduce
node_modules
Expected behavior
The Action should not fail if a directory it tries to delete doesn't exist, it should simply skip it and proceed with deletion of the next directory/file it is directed to.
Your YAML file
The text was updated successfully, but these errors were encountered: