command/run: set reader err if ctx is cancelled #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmethakanbesel
requested review from
ilkinulas and
sonmezonur
and removed request for
a team
sonmezonur
reviewed
Jul 25, 2023
| @@ -197,6 +198,10 @@ func (r *Reader) read() { | |||
| } | |||
| if err != nil { | |||
| if err == io.EOF { | |||
| if errors.Is(r.ctx.Err(), context.Canceled) { | |||
| r.err = r.ctx.Err() | |||
| return | |||
There was a problem hiding this comment.
does not need early-return here. the following line already returns with an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r.errshould be set manually whenEOFis received beforecontext.Canceled.It is important to stop the execution of Goroutines which use one common context.
Necessary for PR #597
Any other solutions are welcome.