command/sync: handle object listing errors #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmethakanbesel
requested review from
ilkinulas and
sonmezonur
and removed request for
a team
sonmezonur
requested changes
Jul 18, 2023
sonmezonur
previously approved these changes
Jul 25, 2023
ilkinulas
reviewed
Jul 27, 2023
Co-authored-by: İlkin Balkanay <ilkinulas@gmail.com>
ilkinulas
reviewed
Jul 27, 2023
sonmezonur
previously approved these changes
Jul 28, 2023
sonmezonur
previously approved these changes
Jul 28, 2023
sonmezonur
approved these changes
Jul 28, 2023
ilkinulas
reviewed
Aug 4, 2023
| } | ||
|
|
||
| // sync --exit-on-error s3://bucket/* s3://NotExistingBucket/ (dest bucket doesn't exist) | ||
| func TestSyncExitOnErrorS3BucketToS3BucketThatDoesNotExist(t *testing.T) { |
There was a problem hiding this comment.
This test case does not adequately test the --exit-on-error flag, because if the bucket does not exist, the flag will have no effect. It would be better to test the flag with an error other than "AccessDenied" or "NoSuchBucket".
ilkinulas
approved these changes
Aug 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #564
Changes are made:
exit-on-errorflag. Its value isfalseby default.shouldStopSyncfunction. It determines whether a sync process should be stopped or not. It does not ignore the errorsAccessDeniedandNoSuchBucketregardless of the value ofexit-on-errorflag.synccommand stops if an error is received when listing objects from source or destination when theexit-on-errorflag istrue. But it always ignores theErrNoObjectFounderror.