Skip to content

Commit

Permalink
The observer code now longer generates deprecated return value reference
Browse files Browse the repository at this point in the history
notices.

Bug: 18830
  • Loading branch information
jparise committed Sep 18, 2011
1 parent 364686e commit 2e842ee
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 6 deletions.
6 changes: 3 additions & 3 deletions Log/observer.php
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function &factory($type, $priority = PEAR_LOG_INFO, $conf = array())
* instance.
*/
if (class_exists($class)) {
$object = &new $class($priority, $conf);
$object = new $class($priority, $conf);
return $object;
}

Expand All @@ -102,9 +102,9 @@ function &factory($type, $priority = PEAR_LOG_INFO, $conf = array())
if (class_exists($class)) {
/* Support both new-style and old-style construction. */
if ($newstyle) {
$object = &new $class($priority, $conf);
$object = new $class($priority, $conf);
} else {
$object = &new $class($priority);
$object = new $class($priority);
}
return $object;
}
Expand Down
1 change: 1 addition & 0 deletions package.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
$version = '1.12.7';
$notes = <<<EOT
- The 'firebug' handler is now usable with Chrome, as well. (Request 18617)
- The 'observer' code now longer generates deprecated return value reference notices. (Bug 18830)
EOT;

$package = new PEAR_PackageFileManager2();
Expand Down
8 changes: 5 additions & 3 deletions package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
<email>jan@horde.org</email>
<active>yes</active>
</lead>
<date>2011-07-16</date>
<time>19:04:29</time>
<date>2011-09-18</date>
<time>16:55:38</time>
<version>
<release>1.12.7</release>
<api>1.0.0</api>
Expand All @@ -38,6 +38,7 @@
<license uri="http://www.opensource.org/licenses/mit-license.php">MIT License</license>
<notes>
- The &apos;firebug&apos; handler is now usable with Chrome, as well. (Request 18617)
- The &apos;observer&apos; code now longer generates deprecated return value reference notices. (Bug 18830)
</notes>
<contents>
<dir baseinstalldir="/" name="/">
Expand Down Expand Up @@ -148,10 +149,11 @@
<release>stable</release>
<api>stable</api>
</stability>
<date>2011-07-16</date>
<date>2011-09-18</date>
<license uri="http://www.opensource.org/licenses/mit-license.php">MIT License</license>
<notes>
- The &apos;firebug&apos; handler is now usable with Chrome, as well. (Request 18617)
- The &apos;observer&apos; code now longer generates deprecated return value reference notices. (Bug 18830)
</notes>
</release>
<release>
Expand Down

0 comments on commit 2e842ee

Please sign in to comment.