- disabled 1-indexing in bindParam() and bindColumn() until its absol…

…utely clear that PDO will stay this way

git-svn-id: http://svn.php.net/repository/pear/packages/MDB2/trunk@185279 c90b9560-bf6c-de11-be94-00142212c4b1

MDB2.php

@@ -2842,7 +2842,7 @@ function getResource()
     function bindColumn($column, &$value, $type = null)
     {
         if (is_numeric($column)) {
-            --$column;
+// todo     --$column;
         } else {
             $column_names = $this->getColumnNames();
             if ($this->db->options['portability'] & MDB2_PORTABILITY_LOWERCASE) {
@@ -2969,7 +2969,7 @@ function MDB2_Statement_Common(&$db, &$statement, $query, $types, $result_types)
     function bindParam($parameter, &$value, $type = null)
     {
         if (is_numeric($parameter)) {
-            --$parameter;
+// todo     --$parameter;
         } else {
             $parameter = preg_replace('/^:(.*)$/', '\\1', $parameter);
         }

package.php

@@ -48,7 +48,6 @@
 - ensure that types are numerically keyed in setResultTypes()
 - added caching to getColumnNames()
 - added bindColumn() support
-- made bindParam() 1-indexed for numeric parameters (as PDO does; BC break!)
 EOT;
 
 $description =<<<EOT

tests/MDB2_bugs_testcase.php

@@ -116,7 +116,7 @@ function clearTables() {
 
     function insertTestValues(&$stmt, &$data) {
         for ($i = 0; $i < count($this->fields); $i++) {
-            $stmt->bindParam($i+1, $data[$this->fields[$i]]);
+            $stmt->bindParam($i, $data[$this->fields[$i]]);
         }
     }
 

tests/MDB2_usage_testcase.php

@@ -125,7 +125,7 @@ function supported($feature) {
 
     function insertTestValues(&$stmt, &$data) {
         for ($i = 0; $i < count($this->fields); $i++) {
-            $stmt->bindParam($i+1, $data[$this->fields[$i]]);
+            $stmt->bindParam($i, $data[$this->fields[$i]]);
         }
     }
 
@@ -349,7 +349,7 @@ function testPreparedQueries() {
         $stmt = $this->db->prepare("INSERT INTO users (user_name, user_password, user_id) VALUES (?, $question_value, 1)", array('text'));
 
         $value = 'Sure!';
-        $stmt->bindParam(1, $value);
+        $stmt->bindParam(0, $value);
 
         $result = $stmt->execute();
 
@@ -809,8 +809,8 @@ function testAffectedRows() {
         for ($row = 0; $row < $total_rows; $row++) {
             $password = "another_password_$row";
             if ($row == 0) {
-                $stmt->bindParam(1, $password);
-                $stmt->bindParam(2, $row);
+                $stmt->bindParam(0, $password);
+                $stmt->bindParam(1, $row);
             }
 
             $result = $stmt->execute();
@@ -827,7 +827,7 @@ function testAffectedRows() {
         $stmt = $this->db->prepare('DELETE FROM users WHERE user_id >= ?', array('integer'));
 
         $row = intval($total_rows / 2);
-        $stmt->bindParam(1, $row);
+        $stmt->bindParam(0, $row);
         for ($row = $total_rows; $total_rows; $total_rows = $row) {
             $row = intval($total_rows / 2);