Trunk #1
Merged
Trunk #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tmplCode flag for complex framework template - Added --template-code from command line for complex framework template - Added doctest for new tmplCode flag - Fixed docs/test1.php file - Fixed return code of phpdt for fail or error in doctest execution and parsing - Fixed execution of doctest even if parsing error occur
Fixed pear code rule
- Added tmpl_code.doctest.php file
| } | ||
| } | ||
|
|
||
| } catch( Exception $e ) { | ||
| $this->_testCase->parsingError = $e->getMessage(); |
There was a problem hiding this comment.
This unfortunately will tend to lose backtrace information if it's some other exception you don't expect. Can you catch a more specific exception?
There was a problem hiding this comment.
Yes, you are right. I will make another pull for that.
|
Probably worth running PHPCS over the changes. |
|
Looks good to me. |
izimobil
added a commit
that referenced
this pull request
Jan 14, 2013
|
For the record, just fixed this hardcoded path: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
I have merged all my locals changes in this fork. I have also executed phpdt over doctest pear dir and all works fine. Let me know if you need more information.
You could find comments for new features and fix over the commit message but feel free to contact me.
Cheers
Tobia