Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly authenticate at proxy server. #72

Closed
wants to merge 1 commit into from

Conversation

yunosh
Copy link
Member

@yunosh yunosh commented Oct 23, 2017

This fixes "Establishing a CONNECT tunnel through proxy failed with response code 407" errors.

This fixes "Establishing a CONNECT tunnel through proxy failed with response code 407" errors.
Copy link
Member

@kenguest kenguest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "Proxy-Authorization" header should be conditional on authentication values being set - what happens if null is returned by getProxyAuth?

ashnazg added a commit to ashnazg/pear-core that referenced this pull request Jul 20, 2018
@ashnazg ashnazg mentioned this pull request Jul 20, 2018
@ashnazg
Copy link
Member

ashnazg commented Jul 20, 2018

Implementing this change on PR #77 in order to include requested feedback.

@ashnazg ashnazg closed this Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants