Increased attack time on piano resonance #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you play a note on a piano, the pitch tends to be slightly flat at first and take a fraction of a second to settle down to the correct frequency. This can cause problems when using higher notes to emulate string resonance. Depending on the particular samples being played, they can momentarily be out of tune with each other. The problem can be fixed by increasing the attack time on the resonance samples to give the pitch more time to settle down.