Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pubspec #169

Closed
wants to merge 4 commits into from
Closed

Conversation

hellcp
Copy link
Collaborator

@hellcp hellcp commented Jun 3, 2021

Most of the changes are from riverpod, from the following change: rrousselGit/riverpod#341
There were also slight changes in Uuid, but they are more obvious

The dependencies blocked by other dependencies were marked

@matejdro matejdro requested a review from DreadBoy June 4, 2021 05:08
@hellcp
Copy link
Collaborator Author

hellcp commented Jun 4, 2021

I also rebased device_calendar on the latest devel, but I will leave that for another time (and branch), since it's a lot of fixing null safety after their rewrite among other things https://github.com/hellcp/device_calendar/tree/rebble

And maybe if the upstream is fast enough, we can get that merged and get a release with those changes soon

@hellcp hellcp mentioned this pull request Jun 4, 2021
1 task
Copy link
Collaborator

@DreadBoy DreadBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static analysis finds problems in app in test, check out "Dart Analysis" tab in IntelliJ or log from CI

@matejdro matejdro requested a review from DreadBoy June 14, 2021 14:38
@hellcp hellcp marked this pull request as draft July 16, 2021 18:01
@hellcp
Copy link
Collaborator Author

hellcp commented Jul 16, 2021

I'm switching this to draft since I noticed breaking change of not being able to connect to the watch anymore (which is pretty useful)

@NoahAndrews
Copy link
Contributor

NoahAndrews commented Mar 26, 2022

When I first installed an app from this branch, I was able to pair to a watch, but sending pings and test notifications did not work.

I then added a tiny bit of logging to the Android layer, installed the new APK (no hot reload), and sending pings and test notifications started working.

I'm not too sure what to make of that, but at least it's not entirely broken.

It's also worth noting that I did not have any watch connection issues with #201

@hellcp
Copy link
Collaborator Author

hellcp commented Mar 26, 2022

I should come back to this branch at some point to test it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants