Add keep selection feature #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sixeight
force-pushed
the
patch/keep-selection
branch
from
d6c4d4b
to
411a8eb
Compare
| @@ -497,7 +498,13 @@ func (m *CustomMatcher) Line(quit chan struct{}, q string, buffer []Line) []Line | |||
| for { | |||
| b, _, err := buf.ReadLine() | |||
| if len(b) > 0 { | |||
| iter <- NewMatchedLine(string(b), m.enableSep, nil) | |||
| for i, line := range lines[idx:] { | |||
There was a problem hiding this comment.
コードを細かく見てないんですが、このループの効率の悪さが若干気になります…
他に方法はないものでしょうか
There was a problem hiding this comment.
指摘ありがとうございます！
いい方法がぱっと思いつかなくて苦し紛れでした…。
なにか妙案がないか考えてみてますが、いまの Custom Matcher のときの選択のロジックから元の行数を得るのはなかなか難しそうな気がしています。
There was a problem hiding this comment.
子供と風呂に入りながら「ああ、そういうことだな」と気づきましたｗ＞CustomMatcher
仕様変えないと難しそうですね
There was a problem hiding this comment.
もともとの仕様はシンプルで CustomMatcher 作りやかったので、余計なことをしてしまったかもしれません 😲
といいつつ絞り込みつつ選択していくのはべんりだと思っているのでいい塩梅になるといいのですが。
|
これ、僕の元の選択されてるバッファを作るところの質がいけてないんですよねぇ。 |
lestrrat
added a commit
that referenced
this pull request
Mar 13, 2015
By default this feature is disabled, keeping backward compatibiity. This should fix #230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief
I propose keep selection feature.
Merge this patch then selection is kept when applied new query.
Thus we select multi line with incremental search.
Use case
git ls-fileresult.gibo -lresult (simonwhitaker/gibo)thank you.