Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump versions, fixes, doc updates. #620

Merged
merged 6 commits into from Jun 7, 2019
Merged

Bump versions, fixes, doc updates. #620

merged 6 commits into from Jun 7, 2019

Conversation

ddeaguiar
Copy link
Contributor

@ddeaguiar ddeaguiar commented Jun 4, 2019 •
edited

  • Bumps project dependencies.
    • There were a number of vulnerabilities reported for the previous Jetty
      version as per the OWASP Dependency Check tool
      (https://www.owasp.org/index.php/OWASP_Dependency_Check). Changes were benchmarked
      locally using lein benchmark-service + service/bin/perfit.sh and showed no significant
      difference.
  • Jetty HttpConfiguration can now be set via :container-options.

Resolves #619, #615.

@ddeaguiar
Bump Jetty version
77e0e99 
There were a number of vulnerabilities reported for the previous Jetty
version as per the OWASP Dependency Check tool (https://www.owasp.org/index.php/OWASP_Dependency_Check).
@ddeaguiar ddeaguiar requested a review from solussd June 4, 2019 19:04
ohpauleez
ohpauleez approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@ohpauleez ohpauleez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to bump other deps if you want to just change the PR to be a deps refresh across the board

@ddeaguiar
Copy link
Contributor Author

@ohpauleez good idea. I was planning on cutting a release after these changes landed as well.

@ohpauleez
Copy link
Member

ohpauleez commented Jun 5, 2019 •
edited

I would like to see this issue fixed before the release: #615

In summary, the http-configuration function should also destructure an :http-configuration option, which will short-circuit the function and return that configuration.

@ohpauleez
Copy link
Member

Let's also address: #585 and #594

@ddeaguiar
Copy link
Contributor Author

👍

@ddeaguiar ddeaguiar changed the title Bump Jetty version Bump versions, fixes, doc updates. Jun 7, 2019
@ddeaguiar
Copy link
Contributor Author

I've bumped deps but still need to run some tests.

ohpauleez
ohpauleez reviewed Jun 7, 2019
View reviewed changes
Copy link
Member

@ohpauleez ohpauleez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic changeset! Thanks for all the hard work!

service/src/io/pedestal/http.clj Outdated Show resolved Hide resolved
service/src/io/pedestal/http.clj Outdated Show resolved Hide resolved
@ddeaguiar ddeaguiar merged commit 8fe59f3 into master Jun 7, 2019
@ddeaguiar ddeaguiar deleted the jetty/address-vulnerabilities branch June 7, 2019 19:35
@ddeaguiar ddeaguiar mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohpauleez ohpauleez ohpauleez approved these changes

@solussd solussd Awaiting requested review from solussd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pedestal dependencies have CVEs of high/critical severity
2 participants
@ddeaguiar @ohpauleez