Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not log Broken pipe exception #621
When using with Immutant, Pedestal logs Broken pipe errors quite often. As far as I understand, those are nothing to be afraid of, just client silently closing TCP connection while other side is not informed about it and tries to write. This is a part of normal operation and definitely should not dominate your logs:
Hi @tonsky, I really appreciate your interest in making Pedestal better! While I appreciate the intent to reduce log noise, I don't think such a specific change belongs in the
That being said, although possible, there is no easy way for a service implementor to handle any exception as responses are streaming. As per the
Ideally a service implementor would have the ability to provide a service-specific error handling interceptor to handle errors such as this. The bottom line is that I think a more general solution is needed. I'm going to create an issue about this and close this PR.