Fix Pedestal Issue #610 #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
url-for throws and exception when a context path is supplied and used for a route with a path parameter in the first segment.
hlship
approved these changes
May 10, 2023
route/src/io/pedestal/http/route.clj
Outdated
| @@ -249,7 +249,7 @@ | |||
| :context-path-parts context-path-parts) | |||
| ;;(concat context-path-parts path-parts) | |||
There was a problem hiding this comment.
This comment should be deleted.
|
Above changes accidental, this was fixed in 0.6.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#610
url-forthrows and exception when a context path is supplied and used for a route with a path parameter in the first segment.The logic appeared to assume that path segments are always strings and was using
empty?to check for the empty string.empty?expects a sequence. A keyword is not a sequence, so empty was throwing an exception.