Stop daemonizing #14
Open
Stop daemonizing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuchemb
reviewed
Mar 31, 2022
leoplo
force-pushed
the
stop_daemonizing
branch
2 times, most recently
from
ef28219
to
5d520b7
Compare
pedrofran12
force-pushed
the
master
branch
3 times, most recently
from
4070f07
to
5a45b31
Compare
|
Hi Léo-Paul, Thank you again for your PR and sorry for the delay. So far I have tested your PR and the start of the process looks ok in the foreground process as well on the background with "&" and "setsid". Also noticed that command "-instances" is broken:
Thank you again :) |
leoplo
force-pushed
the
stop_daemonizing
branch
6 times, most recently
from
bf3c47a
to
d24bf42
Compare
leoplo
force-pushed
the
stop_daemonizing
branch
from
d24bf42
to
40b363e
Compare
Return a tuple for vrfs instead of a list
On stop command call Main.stop() runs
`remove_interface("*", pim=True, membership=True, ipv4=True, ipv6=True)`.
Therefore if a PIM interface was added for network interface eth0, the call
`remove_interface('eth0', True, True)` will evaluate the condition
`membership and not membership_interface` as True and the PIM interface will
never be removed.
Furthermore
`remove_interface("*", pim=True, membership=True, ipv4=True, ipv6=True)` will
do calls like `remove_interface('lo', True, True)` then calling
`remove_virtual_interface('lo')` and the line
`index = self.vif_name_to_index_dic.pop(interface_name, None)` will cause a
KeyError when running
`del self.vif_name_to_index_dic[self.vif_index_to_name_dic[index]]` or
`mif_index = self.vif_name_to_index_dic.pop(interface_name)`.
As running stop and then start is the default behavior for daemon managing tools restart command, the current restart command looks pointless.
leoplo
force-pushed
the
stop_daemonizing
branch
from
40b363e
to
4a24b74
Compare
exit class can be used to handle signals and do proper cleaning before killing a process
Run pim-dm in foreground
Exit with an error if config command fails because 'PyYAML' is missing.
Wait for thread loop to return when exiting
leoplo
force-pushed
the
stop_daemonizing
branch
from
4a24b74
to
4490041
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.