-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: star/unstar messages #494
feat: star/unstar messages #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good functionality-wise!
I would argue that the functions on client
and chat
don't seem to be really useful- calling the function directly on the Message seems to me more natural. I see you suggested using IDs for the functions on client/chat, but to be honest I think I'd prefer just leaving it on the Message and removing the functions from client/chat, unless you see a use case where it would be more convenient to have those.
I think you're right. It's done. |
* 'master' of https://github.com/pedroslopez/whatsapp-web.js: chore: mark version v1.12.0 docs: switch links to point to the guide docs: fix error generating Label docs feat: Get message delivery information (close pedroslopez#418) feat: mark chat as unread (pedroslopez#475) feat: add GroupChat types (pedroslopez#485) docs: fix typo feat: added starred indicator to messages (pedroslopez#501) feat: star/unstar messages (pedroslopez#494) feat: get Contact's "About" text (close pedroslopez#491) feat: get links included in message (pedroslopez#457) feat: send media as stickers (pedroslopez#479) docs: fix slight typo feat: send media as document (pedroslopez#490) feat: Get registered ID for a given phone number (pedroslopez#483) feat(interface): Open chat search, open chat at message position (pedroslopez#447) feat: WA Business Labels support (pedroslopez#407) # Conflicts: # package.json
adds functions to star/unstar messages to
client
,chat
andmessage
.Usage:
Result (bot point of view):
![image](https://user-images.githubusercontent.com/20830847/102955060-ce8b4300-44b3-11eb-9e3c-3420c75304a4.png)
Would it be better if
client.starMsgs
andchat.starMsgs
receives an array of IDs instead of messages?closes #481