Adding / Deleting Profile Picture #652

PurpShell · 2021-04-27T17:52:36Z

Profile Picture functionality

INFO

This pull request is adding the way to set and delete profile pictures.

Currently, this only works with chats in cache, (ProfilePicThumb),
I will see if I can change that though..

It automatically resizes any unfitting dimensions, picking the left of an image.. Recommended dimensions are 640*640.

YOU CAN ONLY SET / DELETE PFPs TO GROUPS and YOURSELF
(you must be able to do it on your own by default)
(you must have group admin on any chat that has restricting editing info only to admins)

EDIT (May 4, 2021): THIS HAS BEEN TESTED FOR 7 DAYS.. All seems working with no bans and no potential risk of being banned.

VIDEO DEMO:

output.mp4

USAGE

This pull request adds two methods.

client.setProfilePicture(id, picture):
- Parameters:
- id : String (Chat ID to set)
- picture: MessageMedia instance of the image you want to be set.
- Returns:
Image URL / False
client.deleteProfilePicture(id):
- Parameters:
- id : String (Chat ID to delete from)
- Returns:
True / False
Also 2 sub-methods for a GroupChat instance:

chat.setProfilePicture(picture):
- Parameters:
- picture: MessageMedia instance of the image you want to be set.
- Returns:
Image URL / False

chat.deleteProfilePicture():
- Parameters:
none
- Returns:
True / False

Update to v.1.12.6

guicuton · 2021-05-12T20:09:05Z

When these methods will be merged? They would be very usefull :-)

bernardoely · 2021-05-21T20:36:52Z

Looking forward to getting this functionality!! Really appreciate if you can merge this. Thanks.

pedroslopez

This is great! Thanks for adding this.

I think to avoid confusion we should leave client.setProfilePicture and client.removeProfilePicture to deal with the current user's profile and let groupChat.setProfilePicture / groupChat.removeProfilePicture deal with the group's picture. You can then move common functionality to Injected.js

pedroslopez · 2021-06-01T00:51:41Z

src/structures/GroupChat.js

+     * @returns {Promise<Boolean>} true if it succeeded / false if it didn't delete the profile picture.
+     */
+    async deleteProfilePicture() {
+        return await this.client.setProfilePicture(this.id._serialized);


Should this be calling deleteProfilePicture instead of setProfilePicture?

oops

I usually make PRs locally and test then re-type it out in github's editor..

I am going to use git functions from now on, overall less mistakes

Thanks for putting an eye on this, sorry for the confusion

replaced with single quotes

Murilandrade · 2021-06-12T12:20:13Z

when I try to do that I get an erro on the window.mR.findModule('setProfilePic')[0]; is there a solution for this?

PurpShell · 2021-06-12T15:13:50Z

when I try to do that I get an erro on the window.mR.findModule('setProfilePic')[0]; is there a solution for this?

I will check it out. i still have to re-factor the code anyways so I will have to find the module by collection and not the method name itself

Best regards,

PurpShell

PurpShell · 2021-06-12T15:14:36Z

As you might have seen, the PR has been put on draft mode and the eslint failed

bragarpaulo · 2021-06-16T03:04:11Z

Very nice this!!!! I hope to use it soon.

Congrats @PurpShell & @pedroslopez

eslint fix for your Pull request

eowoosh · 2021-07-11T04:40:36Z

@PurpShell Hello! It's possible you share function Util.formatImageToProfilePic() ?

TypeError: Util.formatImageToProfilePic is not a function

dbsdenis · 2021-07-19T01:57:19Z

@PurpShell Hello! É possível compartilhar a função Util.formatImageToProfilePic ()?

TypeError: Util.formatImageToProfilePic is not a function

Exemplo de uso:

if (msg.body === '!addpicture') {
    // Add picture the group
    let chat = await msg.getChat();
    let picture = MessageMedia.fromFilePath("image.png");
    if (chat.isGroup) {
        await client.setProfilePicture(chat.id._serialized, picture);
    } else {
        msg.reply('This command can only be used in a group!');
    }
}

if (msg.body === '!removepicture') {
    // Remove picture the group
    let chat = await msg.getChat();
    if (chat.isGroup) {
        await client.deleteProfilePicture(chat.id._serialized);
    } else {
        msg.reply('This command can only be used in a group!');
    }
}

src/util/Util.js

/**
 * Formats a image to profile picture
 * @param {MessageMedia} media
 * 
 * @returns {Promise<MessageMedia>} media in picture format
 */
static async formatImageToProfilePic(media) {

    if (!media.mimetype.includes('image'))
        throw new Error('media is not a image');

    const buff = Buffer.from(media.data, 'base64');

    let preview = sharp(buff).resize(96, 96);
    let img = sharp(buff).resize(640, 640);
  
    preview = `data:${media.mimetype};base64,${(await preview.toBuffer()).toString('base64')}`;
    img = `data:${media.mimetype};base64,${(await img.toBuffer()).toString('base64')}`;

    return {             
        img,
        preview
    };
}

PurpShell · 2021-07-28T14:15:28Z

@PurpShell Hello! É possível compartilhar a função Util.formatImageToProfilePic ()?
TypeError: Util.formatImageToProfilePic is not a function

Exemplo de uso:

if (msg.body === '!addpicture') {
    // Add picture the group
    let chat = await msg.getChat();
    let picture = MessageMedia.fromFilePath("image.png");
    if (chat.isGroup) {
        await client.setProfilePicture(chat.id._serialized, picture);
    } else {
        msg.reply('This command can only be used in a group!');
    }
}

if (msg.body === '!removepicture') {
    // Remove picture the group
    let chat = await msg.getChat();
    if (chat.isGroup) {
        await client.deleteProfilePicture(chat.id._serialized);
    } else {
        msg.reply('This command can only be used in a group!');
    }
}

src/util/Util.js

/**
 * Formats a image to profile picture
 * @param {MessageMedia} media
 * 
 * @returns {Promise<MessageMedia>} media in picture format
 */
static async formatImageToProfilePic(media) {

    if (!media.mimetype.includes('image'))
        throw new Error('media is not a image');

    const buff = Buffer.from(media.data, 'base64');

    let preview = sharp(buff).resize(96, 96);
    let img = sharp(buff).resize(640, 640);
  
    preview = `data:${media.mimetype};base64,${(await preview.toBuffer()).toString('base64')}`;
    img = `data:${media.mimetype};base64,${(await img.toBuffer()).toString('base64')}`;

    return {             
        img,
        preview
    };
}

this is different from my way, though i haven't been able to push since i have been getting issues with sharp.

also the way you do this is very bad, resizing an image of any dimension / aspect ratio, and also not providing the format in JPEG.

dbsdenis · 2021-07-28T14:17:27Z

@PurpShell Hello! É possível compartilhar uma função Util.formatImageToProfilePic ()?
TypeError: Util.formatImageToProfilePic is not a function

Exemplo de uso:

if (msg.body === '!addpicture') {
    // Add picture the group
    let chat = await msg.getChat();
    let picture = MessageMedia.fromFilePath("image.png");
    if (chat.isGroup) {
        await client.setProfilePicture(chat.id._serialized, picture);
    } else {
        msg.reply('This command can only be used in a group!');
    }
}

if (msg.body === '!removepicture') {
    // Remove picture the group
    let chat = await msg.getChat();
    if (chat.isGroup) {
        await client.deleteProfilePicture(chat.id._serialized);
    } else {
        msg.reply('This command can only be used in a group!');
    }
}

src/util/Util.js

/**
 * Formats a image to profile picture
 * @param {MessageMedia} media
 * 
 * @returns {Promise<MessageMedia>} media in picture format
 */
static async formatImageToProfilePic(media) {

    if (!media.mimetype.includes('image'))
        throw new Error('media is not a image');

    const buff = Buffer.from(media.data, 'base64');

    let preview = sharp(buff).resize(96, 96);
    let img = sharp(buff).resize(640, 640);
  
    preview = `data:${media.mimetype};base64,${(await preview.toBuffer()).toString('base64')}`;
    img = `data:${media.mimetype};base64,${(await img.toBuffer()).toString('base64')}`;

    return {             
        img,
        preview
    };
}

isso é diferente do meu jeito, embora eu não tenha conseguido empurrar desde que comecei a ter problemas com sharp.

além disso, a maneira como você faz isso é muito ruim, redimensionando uma imagem de qualquer dimensão / relação de aspecto e também não fornecendo o formato em JPEG.

It's temporary, but it works... 😁

PurpShell · 2021-08-04T17:49:21Z

I am working on this pull request again! Sorry for the long wait! I'll work more on this on my windows machine, since no sharp issues there! So far I've tried to imitate the original way the function worked, but it seems like something has either changed or i'm getting it wrong. Excuse me for not providing the util function! I reset my node_modules a bunch of times since April, which caused me to lose the function.

PurpShell · 2021-08-27T21:52:05Z

Update: even after fixing the util function, some change has occurred in whatsapp web that doesn't allow me to set a profile picture

I'll look into it in the following days

stale · 2021-10-11T06:13:37Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

PurpShell · 2021-10-12T13:31:30Z

my issues with sharp aren't bad.. I think I can try to extract the tools wa uses to crop and get the photo

PurpShell · 2021-12-10T13:05:43Z

Since I am getting rid of sharp, which this PR uses, I will also find the functions whatsapp uses to resize the image, and finally settle this issue

DangerD1024 · 2022-01-07T12:30:23Z

Hi, when you will merge that? =)

PurpShell added 9 commits April 25, 2021 15:32

🔀 Update to v.12.6 from pedroslopez/master

72fd178

Update to v.1.12.6

:sparkles Exposed Profile Picture Methods

6d53af8

✨ main methods

80f130e

✨ Added subtypes for group chats

986c52e

🏷️ Adding types

6058453

🐛 null => false

7c1493b

🏷️ Fix all types.

f827a80

🏷️ Make sense of typings

6d9e015

🏷️ Make the type more intuitive

6782ae0

wictornogueira approved these changes Apr 28, 2021

View reviewed changes

🔇 Removed logging function

786134f

PurpShell changed the title ~~Adding Profile Picture functionality~~ Adding / Deleting Profile Picture Apr 29, 2021

PurpShell mentioned this pull request May 1, 2021

Set Group Picture #356

Closed

pedroslopez requested changes Jun 1, 2021

View reviewed changes

PurpShell and others added 2 commits June 1, 2021 09:27

Merge branch 'master' into profilePicture

a9942d6

eslint fix for your Pull request

724a004

replaced with single quotes

PurpShell mentioned this pull request Jun 2, 2021

Is it possible to change the user's profile photo? #308

Closed

Merge branch 'master' into profilePicture

9cac2c1

PurpShell marked this pull request as draft June 5, 2021 21:14

Merge branch 'master' into profilePicture

9ed5a7e

PurpShell mentioned this pull request Jun 11, 2021

Set Group Thumbnail #118

Closed

PurpShell linked an issue Jun 11, 2021 that may be closed by this pull request

Set Group Thumbnail #118

Closed

PurpShell mentioned this pull request Jun 15, 2021

changing the description, image and subject of the group #702

Closed

Merge pull request #4 from Aliyss/patch-2

0b896f3

eslint fix for your Pull request

Gimenz approved these changes Jun 28, 2021

View reviewed changes

Merge branch 'master' into profilePicture

3be0dc0

Merge branch 'main' into profilePicture

779c9b5

Merge branch 'main' into profilePicture

5b93a49

stale bot added the stale label Oct 11, 2021

Merge branch 'main' into profilePicture

3bfba21

PurpShell closed this Nov 11, 2021

fdciabdul mentioned this pull request Jan 19, 2022

Bunch Of Feature Requests #1112

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding / Deleting Profile Picture #652

Adding / Deleting Profile Picture #652

PurpShell commented Apr 27, 2021 •

edited

Loading

guicuton commented May 12, 2021

bernardoely commented May 21, 2021

pedroslopez left a comment

pedroslopez Jun 1, 2021

PurpShell Jun 1, 2021

PurpShell Jun 1, 2021

Murilandrade commented Jun 12, 2021 •

edited

Loading

PurpShell commented Jun 12, 2021

PurpShell commented Jun 12, 2021

bragarpaulo commented Jun 16, 2021

eowoosh commented Jul 11, 2021 •

edited

Loading

dbsdenis commented Jul 19, 2021

PurpShell commented Jul 28, 2021

dbsdenis commented Jul 28, 2021

PurpShell commented Aug 4, 2021

PurpShell commented Aug 27, 2021 •

edited

Loading

stale bot commented Oct 11, 2021

PurpShell commented Oct 12, 2021

PurpShell commented Dec 10, 2021

DangerD1024 commented Jan 7, 2022

Adding / Deleting Profile Picture #652

Adding / Deleting Profile Picture #652

Conversation

PurpShell commented Apr 27, 2021 • edited Loading

Profile Picture functionality

INFO

VIDEO DEMO:

USAGE

guicuton commented May 12, 2021

bernardoely commented May 21, 2021

pedroslopez left a comment

Choose a reason for hiding this comment

pedroslopez Jun 1, 2021

Choose a reason for hiding this comment

PurpShell Jun 1, 2021

Choose a reason for hiding this comment

PurpShell Jun 1, 2021

Choose a reason for hiding this comment

Murilandrade commented Jun 12, 2021 • edited Loading

PurpShell commented Jun 12, 2021

PurpShell commented Jun 12, 2021

bragarpaulo commented Jun 16, 2021

eowoosh commented Jul 11, 2021 • edited Loading

dbsdenis commented Jul 19, 2021

PurpShell commented Jul 28, 2021

dbsdenis commented Jul 28, 2021

PurpShell commented Aug 4, 2021

PurpShell commented Aug 27, 2021 • edited Loading

stale bot commented Oct 11, 2021

PurpShell commented Oct 12, 2021

PurpShell commented Dec 10, 2021

DangerD1024 commented Jan 7, 2022

PurpShell commented Apr 27, 2021 •

edited

Loading

Murilandrade commented Jun 12, 2021 •

edited

Loading

eowoosh commented Jul 11, 2021 •

edited

Loading

PurpShell commented Aug 27, 2021 •

edited

Loading