Update for JDK 17 #292

Jawnnypoo · 2022-03-04T01:36:56Z

Hey there, this project has conflicts and does not work on projects that are targeting JDK 17. Most of this is due to the outdated usages of scrimage, so the bulk of this is updating that usage, but with some bonuses:

removing jcenter
updating dependencies which made things incompatible for JDK 17
update Gradle wrapper

This PR sort of supersedes #288 FYI just since it adds the additional support for JDK 17. Fixes #287

vyguera

Great PR. It looks right for me. It even does much more things than what you say, such as enabling androidx, updating kotlin plugin, updating compile and target SDK and updating compose version (which I think is 1.1.1 for the latest, now)

pedrovgs

Hey @Jawnnypoo thanks for the PR 😃 could you please check code formatting? CI Reports there is an error. You can automatically format the code using a grade task configured. Thank you in advance 😃

pedrovgs · 2022-04-24T13:29:35Z

@Jawnnypoo looks like there is something wrong with the CI config after your update. Can you please take a look so we can ensure the CI is passing before releasing a new version? Thank you in advance 😃

pedrovgs · 2022-04-25T17:14:01Z

@Jawnnypoo I think after merging this PR all our users will be forced to use at least JDK >= 11. Am I wrong?

pedrovgs · 2022-04-25T17:14:58Z

.github/workflows/build.yml

@@ -85,6 +89,10 @@ jobs:
        uses: actions/setup-java@v1
        with:
          java-version: 11
+      - name: Set up JDK 11


Do you mean 17 here?

Oops, good catch

pedrovgs · 2022-04-25T17:15:45Z

.github/workflows/build.yml

@@ -20,6 +20,10 @@ jobs:
        uses: actions/setup-java@v1
        with:
          java-version: 11


Can we remove all the references to previous JDK configs we don't need? I'd like to use the minimum version possible. So if we can use JDK 11, please keep JDK 11 and remove the versions we don't need 😃

Yep, sounds good 👍

Jawnnypoo · 2022-04-25T18:01:44Z

Yeah, that sounds right. The latest Android Studio plugin requires Java 11 if I recall correctly.

Jawnnypoo · 2023-02-22T05:29:19Z

Sorry this took so long, it should be good now, can we rerun this?

Jawnnypoo · 2023-02-22T07:52:10Z

There might be some issues relating to Maven Central and the release signing, but thats not something I can look too much into myself. I confirmed that this branch can be deployed to Jitpack correctly, see https://jitpack.io/com/github/Jawnnypoo/Shot/1b555c2d20/build.log

Jawnnypoo · 2023-02-22T07:54:37Z

If you wanted to try it out:

classpath(com.github.Jawnnypoo.Shot:shot:1b555c2d20)

with:

maven("https://jitpack.io")

configured for buildscript

robertgorterns · 2023-02-23T10:56:03Z

I tried this PR but I get an error running it in my project:

> Task :app:debugExecuteScreenshotTests FAILED
🔎  Comparing screenshots with previous ones.
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:debugExecuteScreenshotTests'.
> Input image must store pixels as ints. Convert your input image using 0
* Try:
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:debugExecuteScreenshotTests'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:142)
	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:282)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:140)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:128)
	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:77)
	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:57)
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:204)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:199)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
	at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
	at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:53)
	at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:73)
	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
	at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:69)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:322)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:309)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:302)
	at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:288)
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:462)
	at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:379)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:49)
Caused by: java.lang.IllegalStateException: Input image must store pixels as ints. Convert your input image using 0
	at thirdparty.romainguy.BlendComposite$BlendingContext.compose(BlendComposite.java:111)
	at com.sksamuel.scrimage.composite.BlenderComposite.apply(BlenderComposite.java:23)
	at com.sksamuel.scrimage.composite.RedComposite.apply(RedComposite.java:5)
	at com.sksamuel.scrimage.ImmutableImage.composite(ImmutableImage.java:509)
	at com.karumi.shot.screenshots.ScreenshotsDiffGenerator.generateDiff(ScreenshotsDiffGenerator.scala:37)
	at com.karumi.shot.screenshots.ScreenshotsDiffGenerator.$anonfun$generateDiffs$1(ScreenshotsDiffGenerator.scala:21)
	at scala.collection.parallel.AugmentedIterableIterator.map2combiner(RemainsIterator.scala:116)
	at scala.collection.parallel.AugmentedIterableIterator.map2combiner$(RemainsIterator.scala:113)
	at scala.collection.parallel.immutable.ParVector$ParVectorIterator.map2combiner(ParVector.scala:66)
	at scala.collection.parallel.ParIterableLike$Map.leaf(ParIterableLike.scala:1056)
	at scala.collection.parallel.Task.$anonfun$tryLeaf$1(Tasks.scala:53)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at scala.util.control.Breaks$$anon$1.catchBreak(Breaks.scala:67)
	at scala.collection.parallel.Task.tryLeaf(Tasks.scala:56)
	at scala.collection.parallel.Task.tryLeaf$(Tasks.scala:50)
	at scala.collection.parallel.ParIterableLike$Map.tryLeaf(ParIterableLike.scala:1053)
	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute(Tasks.scala:153)
	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute$(Tasks.scala:149)
	at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.compute(Tasks.scala:440)
	at scala.collection.parallel.ForkJoinTasks$WrappedTask.sync(Tasks.scala:379)
	at scala.collection.parallel.ForkJoinTasks$WrappedTask.sync$(Tasks.scala:379)
	at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.sync(Tasks.scala:440)
	at scala.collection.parallel.ForkJoinTasks.executeAndWaitResult(Tasks.scala:423)
	at scala.collection.parallel.ForkJoinTasks.executeAndWaitResult$(Tasks.scala:416)
	at scala.collection.parallel.ForkJoinTaskSupport.executeAndWaitResult(TaskSupport.scala:60)
	at scala.collection.parallel.ExecutionContextTasks.executeAndWaitResult(Tasks.scala:555)
	at scala.collection.parallel.ExecutionContextTasks.executeAndWaitResult$(Tasks.scala:555)
	at scala.collection.parallel.ExecutionContextTaskSupport.executeAndWaitResult(TaskSupport.scala:84)
	at scala.collection.parallel.ParIterableLike$ResultMapping.leaf(ParIterableLike.scala:960)
	at scala.collection.parallel.Task.$anonfun$tryLeaf$1(Tasks.scala:53)
	at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
	at scala.util.control.Breaks$$anon$1.catchBreak(Breaks.scala:67)
	at scala.collection.parallel.Task.tryLeaf(Tasks.scala:56)
	at scala.collection.parallel.Task.tryLeaf$(Tasks.scala:50)
	at scala.collection.parallel.ParIterableLike$ResultMapping.tryLeaf(ParIterableLike.scala:955)
	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute(Tasks.scala:153)
	at scala.collection.parallel.AdaptiveWorkStealingTasks$WrappedTask.compute$(Tasks.scala:149)
	at scala.collection.parallel.AdaptiveWorkStealingForkJoinTasks$WrappedTask.compute(Tasks.scala:440)```

Jawnnypoo · 2023-02-23T23:27:11Z

Was it working previously with the latest version of this library?

robertgorterns · 2023-02-27T07:02:31Z

Previously it was working with the last release of shot + java 11. But now my project uses java 17, the main release of shot didn't work, so I tried this branch but I got this error that I hadn't had before

Jawnnypoo · 2023-02-27T20:37:15Z

@pedrovgs I think you'll have to set up CI in a way that it doesn't need release signing unless it is actually pushing out the artifacts to Maven Central

Jawnnypoo · 2023-02-28T01:09:42Z

Removed release signing, should pass now

robertgorterns · 2023-03-13T06:59:23Z

After recording my screenshots again it's working fine!

vudzkostek · 2023-04-15T09:19:57Z

Verified that this also solves issue described under #268. Hope it will be released soon, for now I will use local build in project because it prevents us from upgrading AGP, ComposeCompiler and couple of other things that require JDK 17.

But, as @robertgorterns wrote, it requires re-recording of all screenoshots so worth mentioning in changelog @pedrovgs

robertgorterns · 2023-04-17T05:09:16Z

also when the screenshot tests fail I don't get the proper error response, but the response I commented earlier

core/src/main/scala/com/karumi/shot/screenshots/ScreenshotsDiffGenerator.scala

amatsegor · 2023-05-10T09:11:22Z

@pedrovgs as far as I can see, all the changes are approved and MR is kind of good to go. When could a release with this fix be expected?

Co-authored-by: Nicholas Lythall <nic.lyth@gmail.com>

robertgorterns

I see two build errors

Files incorrectly formatted: /Users/runner/work/Shot/Shot/core/src/main/scala/com/karumi/shot/screenshots/ScreenshotsDiffGenerator.scala

Error: /Users/runner/work/Shot/Shot/core/src/main/scala/com/karumi/shot/screenshots/ScreenshotsDiffGenerator.scala:35:96: not found: value BufferedImage
Error: /Users/runner/work/Shot/Shot/core/src/main/scala/com/karumi/shot/screenshots/ScreenshotsDiffGenerator.scala:36:91: not found: value BufferedImage

robertgorterns · 2023-05-22T09:15:57Z

@Jawnnypoo There are still Build errors with that latest commit

thomasflad · 2023-06-23T09:09:57Z

@Jawnnypoo Thanks again for the work in this PR. Is there something missing to finish it? It seems close

pedrovgs · 2023-07-07T13:56:27Z

The update has been finally impemented here

Update for JDK 17

15187bc

Jawnnypoo mentioned this pull request Mar 8, 2022

Java 17 incompatibility: Unable to make public void sun.nio.ch.ChannelInputStream.close() #268

Closed

vyguera approved these changes Mar 25, 2022

View reviewed changes

vyguera mentioned this pull request Mar 25, 2022

Shot build fails locally on M1 with JDK 17 #287

Open

pedrovgs closed this Apr 23, 2022

pedrovgs reopened this Apr 23, 2022

pedrovgs reviewed Apr 23, 2022

View reviewed changes

Fix code formatting

7132705

pedrovgs approved these changes Apr 24, 2022

View reviewed changes

Jawnnypoo added 2 commits April 25, 2022 12:00

Add JDK 17 to CI

1b450d4

Merge branch 'master' into update

0ff26f1

pedrovgs reviewed Apr 25, 2022

View reviewed changes

Try this config

6e0aa42

pedrovgs closed this Apr 26, 2022

pedrovgs reopened this Apr 26, 2022

mateuszkwiecinski mentioned this pull request May 4, 2022

Gradle Configuration Cache compatibility #263

Closed

MyDogTom mentioned this pull request May 10, 2022

Support configuration cache (second attempt) #307

Merged

FatihYalmanbas mentioned this pull request Feb 2, 2023

Update jdk 17 #333

Closed

Jawnnypoo added 8 commits February 21, 2023 15:48

A few more updates

940519d

Merge branch 'master' into update

13c8aa3

even more updates

344da4b

Update all gradle wrappers

c24f417

Java 11 compat

ebdbcf5

More Java 11 compat

cc451d0

Don't sign if going out to jitpack

945f633

Only publish release variant

1b555c2

Merge branch 'master' into update

1a5498d

Just dont ever sign the release

93354de

vudzkostek approved these changes Apr 14, 2023

View reviewed changes

nicholaslythall reviewed Apr 20, 2023

View reviewed changes

core/src/main/scala/com/karumi/shot/screenshots/ScreenshotsDiffGenerator.scala Outdated Show resolved Hide resolved

vudzkostek mentioned this pull request Apr 24, 2023

Support for Java 17 and AGP 8.0 #336

Open

Always assure ARGB

499f90b

Co-authored-by: Nicholas Lythall <nic.lyth@gmail.com>

robertgorterns approved these changes May 16, 2023

View reviewed changes

robertgorterns suggested changes May 16, 2023

View reviewed changes

MyDogTom mentioned this pull request May 16, 2023

Please consider transferring ownership to the community #340

Closed

Add the import

e82bc9b

Kurt-Bonatz mentioned this pull request Jun 29, 2023

Update various libraries and migrate to JDK 17 #343

Merged

5 tasks

pedrovgs closed this Jul 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update for JDK 17 #292

Update for JDK 17 #292

Jawnnypoo commented Mar 4, 2022 •

edited by pedrovgs

Loading

vyguera left a comment

pedrovgs left a comment

pedrovgs commented Apr 24, 2022

pedrovgs commented Apr 25, 2022

pedrovgs Apr 25, 2022

Jawnnypoo Apr 25, 2022

pedrovgs Apr 25, 2022

Jawnnypoo Apr 25, 2022

Jawnnypoo commented Apr 25, 2022

Jawnnypoo commented Feb 22, 2023

Jawnnypoo commented Feb 22, 2023

Jawnnypoo commented Feb 22, 2023

robertgorterns commented Feb 23, 2023 •

edited

Loading

Jawnnypoo commented Feb 23, 2023

robertgorterns commented Feb 27, 2023

Jawnnypoo commented Feb 27, 2023

Jawnnypoo commented Feb 28, 2023

robertgorterns commented Mar 13, 2023

vudzkostek commented Apr 15, 2023 •

edited

Loading

robertgorterns commented Apr 17, 2023

amatsegor commented May 10, 2023 •

edited

Loading

robertgorterns left a comment

robertgorterns commented May 22, 2023

thomasflad commented Jun 23, 2023

pedrovgs commented Jul 7, 2023

Update for JDK 17 #292

Update for JDK 17 #292

Conversation

Jawnnypoo commented Mar 4, 2022 • edited by pedrovgs Loading

vyguera left a comment

Choose a reason for hiding this comment

pedrovgs left a comment

Choose a reason for hiding this comment

pedrovgs commented Apr 24, 2022

pedrovgs commented Apr 25, 2022

pedrovgs Apr 25, 2022

Choose a reason for hiding this comment

Jawnnypoo Apr 25, 2022

Choose a reason for hiding this comment

pedrovgs Apr 25, 2022

Choose a reason for hiding this comment

Jawnnypoo Apr 25, 2022

Choose a reason for hiding this comment

Jawnnypoo commented Apr 25, 2022

Jawnnypoo commented Feb 22, 2023

Jawnnypoo commented Feb 22, 2023

Jawnnypoo commented Feb 22, 2023

robertgorterns commented Feb 23, 2023 • edited Loading

Jawnnypoo commented Feb 23, 2023

robertgorterns commented Feb 27, 2023

Jawnnypoo commented Feb 27, 2023

Jawnnypoo commented Feb 28, 2023

robertgorterns commented Mar 13, 2023

vudzkostek commented Apr 15, 2023 • edited Loading

robertgorterns commented Apr 17, 2023

amatsegor commented May 10, 2023 • edited Loading

robertgorterns left a comment

Choose a reason for hiding this comment

robertgorterns commented May 22, 2023

thomasflad commented Jun 23, 2023

pedrovgs commented Jul 7, 2023

Jawnnypoo commented Mar 4, 2022 •

edited by pedrovgs

Loading

robertgorterns commented Feb 23, 2023 •

edited

Loading

vudzkostek commented Apr 15, 2023 •

edited

Loading

amatsegor commented May 10, 2023 •

edited

Loading