Update jdk 17 #333
Closed
Update jdk 17 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FatihYalmanbas
commented
Feb 2, 2023
gradle.properties
Outdated
| @@ -10,3 +10,5 @@ POM_LICENCE_NAME=The Apache Software License, Version 2.0 | |||
| POM_LICENCE_URL=http://www.apache.org/licenses/LICENSE-2.0.txt | |||
| POM_DEVELOPER_ID=pedrovgs | |||
| POM_DEVELOPER_NAME=Pedro Vicente Gomez Sanchez | |||
|
|
|||
| android.useAndroidX=true | |||
There was a problem hiding this comment.
This was required when running tests, there is probable other ways of fixing it. Didn't want to add more to this PR
When we don't have any new line at the end of properties file and github workflow appends a RELEASE_SIGNING_ENABLED flag at the end of it, it breaks builds. Add new line to file and prepend it to github job.
5 tasks
|
The update has been finally impemented here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 References
🎩 What is the goal?
AGP 7.4.0 requires plugins to target JDK 11, update shot to enable environments running latest versions
Based on #292, rebased on master and ran tests
How is it being implemented?
Checkout original PR
How can it be tested?