Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previous slides block the current slides when you use wallop--fade.css #54

Closed
Gilberto06 opened this issue Oct 12, 2015 · 5 comments
Closed
Labels

Comments

@Gilberto06
Copy link

Hello, I love this library but I think improving this tiny detail could make it even better.

If the current slide have buttons or a div with scroll they won't work unless you send the previous slides back (z-index: 0) at the end of the animation.

You'll probably find a better solution but changing this in the wallop--fade.css fixed the issue for me:

/*
.Wallop--fade .Wallop-item--hidePrevious,
.Wallop--fade .Wallop-item--hideNext { z-index: 2; }*/
.Wallop--fade .Wallop-item--showPrevious,
.Wallop--fade .Wallop-item--showNext { z-index: 1; }

/========== FADE ANIMATIONS ==========/
@-webkit-keyframes fadeOut {
0% {
opacity: 1;
z-index: 2;
}
99% {
opacity: 0;
z-index: 2;
}
100% {
opacity: 0;
z-index: 0;
}
}
@-moz-keyframes fadeOut {
0% {
opacity: 1;
z-index: 2;
}
99% {
opacity: 0;
z-index: 2;
}
100% {
opacity: 0;
z-index: 0;
}
}
@-ms-keyframes fadeOut {
0% {
opacity: 1;
z-index: 2;
}
99% {
opacity: 0;
z-index: 2;
}
100% {
opacity: 0;
z-index: 0;
}
}
@Keyframes fadeOut {
0% {
opacity: 1;
z-index: 2;
}
99% {
opacity: 0;
z-index: 2;
}
100% {
opacity: 0;
z-index: 0;
}
}

@peduarte
Copy link
Owner

Thanks for this. Will take a better look when I get home.
Quick question, which version of wallop at you using?
@Gilberto06 Can you create a Codepen or jsfiddle with a demo of the problem, please?

@Gilberto06
Copy link
Author

wallop-2.2.2

Here you can see the problem:
http://codepen.io/Gilberto06/pen/pjrMgd

And here you'll find a CSS fix:
http://codepen.io/Gilberto06/pen/XmavRx

On Mon, Oct 12, 2015 at 11:58 PM, Pedro Duarte notifications@github.com
wrote:

Thanks for this. Will take a better look when I get home.
Quick question, which version of wallop at you using?


Reply to this email directly or view it on GitHub
#54 (comment).

Gilbert

@peduarte
Copy link
Owner

Thanks, I'll take a look. 👍

@peduarte peduarte added the bug label Oct 14, 2015
@hnqlv
Copy link
Contributor

hnqlv commented Oct 15, 2015

Po mano arruma ai

@peduarte
Copy link
Owner

This should be fixed now. Please download latest release.
https://github.com/peduarte/wallop/releases/tag/v2.2.3

Test: http://codepen.io/peduarte/pen/NGXJoV

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants