Add 'plugin/'-prefix to namespace and make store not enumerable

peerigon · Aug 6, 2014 · d5c0b26 · d5c0b26
1 parent c90fb66
commit d5c0b26
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/lib/plugin.js b/lib/plugin.js
@@ -5,6 +5,9 @@ function plugin(namespace, fn) {
         throw new TypeError("Cannot create plugin: namespace should be a string, instead saw " + truncate(namespace));
     }
 
+    // Prefix the namespace with 'plugin/' for a better debugging experience
+    namespace = "plugin/" + namespace;
+
     function pluginContext(target) {
         pluginContext.target = target;
 
@@ -15,9 +18,18 @@ function plugin(namespace, fn) {
 
     pluginContext.target = null;
 
-    // TODO Prefix namespace with 'plugin/'
     pluginContext.store = function () {
-        return pluginContext.target[namespace] || (pluginContext.target[namespace] = {});
+        var store = pluginContext.target[namespace];
+
+        if (!store) {
+            store = {};
+            Object.defineProperty(pluginContext.target, namespace, {
+                enumerable: false,
+                value: store
+            });
+        }
+
+        return store;
     };
 
     pluginContext.define = function (key, value) {

diff --git a/test/plugin.test.js b/test/plugin.test.js
@@ -100,12 +100,21 @@ describe("fn's context", function () {
                 applyPlugin();
             });
 
-            it("should store the returned object under obj[pluginNamespace]", function () {
+            it("should store the returned object under obj['plugin/' + pluginNamespace]", function () {
                 createPlugin(function () {
-                    expect(this(obj).store()).to.equal(obj.testPlugin);
+                    expect(this(obj).store()).to.equal(obj["plugin/testPlugin"]);
                 });
                 applyPlugin();
             });
+
+            it("should make the store not enumerable", function () {
+                createPlugin(function () {
+                    this(obj).store();
+                });
+                applyPlugin();
+
+                expect(Object.keys(obj)).to.not.contain("plugin/testPlugin");
+            });
 
             it("should return always the same object for obj", function () {
                 createPlugin(function () {