Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable guest access to view resources #268

Closed
lspgn opened this issue Jul 28, 2020 · 1 comment
Closed

Enable guest access to view resources #268

lspgn opened this issue Jul 28, 2020 · 1 comment
Assignees
Labels
type: bug type: regression Important issue that causes a regression and should be fixed in priority

Comments

@lspgn
Copy link

lspgn commented Jul 28, 2020

Environment

  • Peering Manager version: 1.2.0-dev d4bb98aa27c4

Steps to Reproduce + Observed Behavior

When clicking on any link, if the user is not logged, they will be redirected to the login page.
Tried to disable this feature with:
LOGIN_REQUIRED = False in configuration.py without success.

Expected Behavior

In v1.1.0, the default behavior allowed guest access to the resources. I believe this is preferrable for other teams to be able to easily access the resources without changing them.

@gmazoyer gmazoyer self-assigned this Jul 28, 2020
@gmazoyer gmazoyer added type: bug type: regression Important issue that causes a regression and should be fixed in priority labels Jul 28, 2020
@gmazoyer
Copy link
Member

gmazoyer commented Jul 29, 2020

It looks like it comes from the permission_required = "peering.view_mymodel" which has been introduced to be able to restrict some views to users. I wonder if it's possible to remove the permission requirement if LOGIN_REQUIRED = False.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug type: regression Important issue that causes a regression and should be fixed in priority
Projects
None yet
Development

No branches or pull requests

2 participants