Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to social media in footer for issue 102 #108

Merged
merged 2 commits into from Nov 5, 2016

Conversation

mcmanuss8
Copy link
Contributor

Quick patch to add social media links for issue 102

screen shot 2016-11-04 at 11 46 07 pm

@grizz
Copy link
Member

grizz commented Nov 5, 2016

Looks good. Take out the commented dev_addr line (can use -a locally to serve on another port, I'll add that to the docs), either take out the commented "Documentation built by mkdocs" line, or add it back it, and it'll be good to go.

I'm for leaving the MkDocs credit, but if doesn't look good, by all means drop it, there's already a GitHub link giving them credit.

Thanks!

@mcmanuss8
Copy link
Contributor Author

Yeah, I had it in there originally but it looked awkward...
deleted commented out stuff.

@grizz grizz merged commit 26bee71 into peeringdb:master Nov 5, 2016
@grizz
Copy link
Member

grizz commented Nov 5, 2016

Perfect!

@mcmanuss8 mcmanuss8 deleted the social_media branch November 5, 2016 04:20
@grizz
Copy link
Member

grizz commented Nov 5, 2016

Wasn't deployed correctly because I had an old version of mkdocs, all good now.

@ghankins
Copy link
Contributor

ghankins commented Nov 5, 2016

This issues was logged to add social media badges to the main page too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants