Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo watermark and peeringdb.com URL to kmz #1491

Open
grizz opened this issue Dec 12, 2023 · 12 comments · Fixed by #1621
Open

Add logo watermark and peeringdb.com URL to kmz #1491

grizz opened this issue Dec 12, 2023 · 12 comments · Fixed by #1621
Assignees
Labels
Time:Minor Up to 4 hours

Comments

@grizz
Copy link
Member

grizz commented Dec 12, 2023

Broken out from #1472

Add logo watermark and peeringdb.com URL to show where data is from.

This makes sense to me, +1

@grizz grizz added the Time:Minor Up to 4 hours label Dec 12, 2023
@martinhannigan
Copy link

martinhannigan commented Dec 12, 2023 via email

@leovegoda leovegoda self-assigned this Dec 13, 2023
@leovegoda leovegoda added this to the 1 Decide milestone Dec 13, 2023
@mcmanuss8
Copy link
Contributor

+1

2 similar comments
@peterhelmenstine
Copy link

+1

@jackcarrozzo
Copy link

+1

@peterhelmenstine
Copy link

-1 to do this dynamically

@martinhannigan
Copy link

Looks good in beta, however it's aspect ratio appears off and the color of a portion of the logo is almost too dark to be seen when over ocean and has no contrast when over land. It's also obscured by Google's logo/watermark. The typical watermark I've seen is usually in the left hand corner. Would be great if there could be some bottom/left or right margin.
Screenshot 2024-05-29 at 7 13 42 PM

@martinhannigan
Copy link

It's also missing the PeeringDB URL per the issue AFAICT.

@leovegoda
Copy link
Contributor

This is coded and deployed but not showing up. Might be a cache issue. 20C are investigating.

@martinhannigan
Copy link

martinhannigan commented Jun 7, 2024 via email

@leovegoda
Copy link
Contributor

Code deployed in 2.58.0 and a config change in 2.59.0 made this work

@martinhannigan
Copy link

Tried it with both the network link and a direct download from the front page of PeeringDB. I don't see where there's a URL pointing to peeringdb and the logo is still obscured by the Google logo. I think putting it anywhere except where the Google logo is could help.
Screenshot 2024-06-26 at 5 47 23 PM

@martinhannigan
Copy link

reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Time:Minor Up to 4 hours
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants