Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning for missing information #616

Closed
koalafil opened this issue Jan 4, 2020 · 7 comments
Closed

Warning for missing information #616

koalafil opened this issue Jan 4, 2020 · 7 comments
Assignees
@arnoldnipper @koalafil
Labels
Time:Minor Up to 4 hours
Milestone
2.19.0

Comments

@koalafil
Copy link

koalafil commented Jan 4, 2020

This is a request on behalf of Vladimir Drushchits (raised during Moscow Peering Forum 2019): "We are an ISP so we consider ourselves a Network and not an IXP in PeeringDB. Our Org object constantly pushes warnings to fill in the routeserver information. As an ISP, network, we do not run a routeserver. Could the warnings stop for networks pls? "
@koalafil koalafil added this to the 1 Decide milestone Jan 4, 2020
@koalafil koalafil self-assigned this Jan 4, 2020
@arnoldnipper arnoldnipper self-assigned this Jan 4, 2020
@arnoldnipper
Copy link
Contributor

Currently a warning 'Some of the data on this page is incomplete, please update the fields marked with "!! to improve data quality.' is shown if a field of record net is not set.

Proposal: do not show this warning for fields

  • Route Server URL
  • Looking Glass URL

@mcmanuss8
Copy link
Contributor

+1

@arnoldnipper arnoldnipper changed the title Change warning for missing route server information if the org is a Network Warning for missing informations Jan 7, 2020
@arnoldnipper arnoldnipper changed the title Warning for missing informations Warning for missing information Jan 7, 2020
@arnoldnipper
Copy link
Contributor

Small addition after last call. Currently a warning 'Some of the data on this page is incomplete, please update the fields marked with "!! to improve data quality.' is shown if a field of record net is not set.

Proposal: do not show this warning for fields

  • Route Server URL
  • Looking Glass URL
  • if IPv4 Prefixes or IPv6 Prefixes is set

@arnoldnipper
Copy link
Contributor

@Shawna, @vegu and @grizz: any question on how to implement this?

@grizz grizz added the Time:Minor Up to 4 hours label Jan 22, 2020
@arnoldnipper
Copy link
Contributor

Small addition after last call. Currently a warning 'Some of the data on this page is incomplete, please update the fields marked with "!! to improve data quality.' is shown if a field of record net is not set.

Proposal: do not show this warning for fields

  • Also Known As
  • Route Server URL
  • Looking Glass URL
  • if IPv4 Prefixes or IPv6 Prefixes is set

@vegu
Copy link
Contributor

vegu commented Jan 30, 2020

@arnoldnipper

if IPv4 Prefixes or IPv6 Prefixes is set

I understand this as: don't show a warning for the fields IPv4 Prefixes and IPv6 Prefixes if either of them is set, but show warning for both if neither of them is set - is that correct?

@arnoldnipper
Copy link
Contributor

@vegu, that is correct.

vegu added a commit that referenced this issue Feb 3, 2020
@vegu
remove warning for missing information for fields: aka, looking glass…
b0525b3 
… server url, route server url (#616)

remove warning for missing information for fields: ipv4 prefixes, ipv6 prefixes if either of them is set (#616)
grizz added a commit that referenced this issue Feb 6, 2020
@grizz
Support 202001 (#641)
06805fe 
* remove warning for missing information for fields: aka, looking glass server url, route server url (#616)
remove warning for missing information for fields: ipv4 prefixes, ipv6 prefixes if either of them is set (#616)

* Use autocomplete fields in the admincom controlpanel to speed up loading times (#597)

* Better error reporting for POSTs and PUTs (#610)

* Add operation to API to look for covering prefixes given an IP (#25)
@grizz grizz closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnoldnipper arnoldnipper

@koalafil koalafil

Labels
Time:Minor Up to 4 hours
Projects
None yet
Milestone
2.19.0
Development

No branches or pull requests
5 participants
@grizz @vegu @mcmanuss8 @arnoldnipper @koalafil