Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr 474 ixf import fixes #476

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Pr 474 ixf import fixes #476

merged 2 commits into from
Apr 18, 2019

Conversation

grizz
Copy link
Member

@grizz grizz commented Apr 18, 2019

No description provided.

- clean up wording for import preview
- change `skip` action to `ignore` in import preview
- change action to `noop` when no action is taken because of disabled ixp update
- #390 fixed: Wrong IPs in exports for IX members with multiple links
- clean up wording for import preview
- change `skip` action to `ignore` in import preview
- change action to `noop` when no action is taken because of disabled ixp update
- #390 fixed: Wrong IPs in exports for IX members with multiple links 

merged from dev branch
@codecov-io
Copy link

Codecov Report

Merging #476 into master will increase coverage by 0.06%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #476      +/-   ##
==========================================
+ Coverage   74.44%   74.51%   +0.06%     
==========================================
  Files          71       71              
  Lines        7909     7926      +17     
==========================================
+ Hits         5888     5906      +18     
+ Misses       2021     2020       -1
Impacted Files Coverage Δ
peeringdb_server/export_views.py 94.4% <100%> (ø) ⬆️
peeringdb_server/ixf.py 82.72% <96%> (+1.68%) ⬆️
peeringdb_server/models.py 83.5% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115956c...3262503. Read the comment docs.

@grizz grizz merged commit 7f0d741 into master Apr 18, 2019
@grizz grizz deleted the pr_474_ixf_import_fixes branch October 4, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants