MediaConnection.on("close") callback function is never executed. #1032
Labels
Comments
|
Can confirm I have the same issue. There are also other issues raised about this same bug making the library quite unusable in production situations currently. |
|
Same issue here. |
|
Faced the same issue as well. Been facing it for well over half an year now. |
|
@jonasgloning - I believe this is something that needs to be addressed, as it is a core functionality that doesn't function properly |
jonasgloning
added a commit
that referenced
this issue
Jun 22, 2023
github-actions bot
pushed a commit
that referenced
this issue
Aug 14, 2023
# [1.5.0-rc.1](v1.4.8-rc.1...v1.5.0-rc.1) (2023-08-14) ### Bug Fixes * **datachannel:** sending order is now preserved correctly ([#1038](#1038)) ([0fb6179](0fb6179)), closes [#746](#746) * **deps:** update dependency peerjs-js-binarypack to v1.0.2 ([7452e75](7452e75)) * **deps:** update dependency webrtc-adapter to v8.2.2 ([62402fc](62402fc)) * **deps:** update dependency webrtc-adapter to v8.2.3 ([963455e](963455e)) * **MediaConnection:** `close` event is fired on remote Peer ([0836356](0836356)), closes [#636](#636) [#1089](#1089) [#1032](#1032) [#832](#832) [#780](#780) [#653](#653) ### Features * **DataConnection:** handle close messages and flush option ([6ca38d3](6ca38d3)), closes [#982](#982) * **MediaChannel:** Add experimental `willCloseOnRemote` event to MediaConnection. ([ed84829](ed84829)) * MsgPack/Cbor serialization ([fcffbf2](fcffbf2))
|
🎉 This issue has been resolved in version 1.5.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this issue
Sep 3, 2023
# [1.5.0](v1.4.7...v1.5.0) (2023-09-03) ### Bug Fixes * **datachannel:** sending order is now preserved correctly ([#1038](#1038)) ([0fb6179](0fb6179)), closes [#746](#746) * **deps:** update dependency @swc/helpers to ^0.4.0 ([a7de8b7](a7de8b7)) * **deps:** update dependency cbor-x to v1.5.4 ([c1f04ec](c1f04ec)) * **deps:** update dependency eventemitter3 to v5 ([caf01c6](caf01c6)) * **deps:** update dependency peerjs-js-binarypack to v1.0.2 ([7452e75](7452e75)) * **deps:** update dependency webrtc-adapter to v8 ([431f00b](431f00b)) * **deps:** update dependency webrtc-adapter to v8.2.2 ([62402fc](62402fc)) * **deps:** update dependency webrtc-adapter to v8.2.3 ([963455e](963455e)) * **MediaConnection:** `close` event is fired on remote Peer ([0836356](0836356)), closes [#636](#636) [#1089](#1089) [#1032](#1032) [#832](#832) [#780](#780) [#653](#653) * **npm audit:** Updates all dependencies that cause npm audit to issue a warning ([6ef5707](6ef5707)) ### Features * `.type` property on `Error`s emitted from connections ([#1126](#1126)) ([debe7a6](debe7a6)) * `PeerError` from connections ([ad3a0cb](ad3a0cb)) * **DataConnection:** handle close messages and flush option ([6ca38d3](6ca38d3)), closes [#982](#982) * **MediaChannel:** Add experimental `willCloseOnRemote` event to MediaConnection. ([ed84829](ed84829)) * MsgPack/Cbor serialization ([fcffbf2](fcffbf2)) * MsgPack/Cbor serialization ([#1120](#1120)) ([4367256](4367256)), closes [#611](#611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the documentation, the MediaConnection object returned after a peer.call(' id ') call can call the close method to destroy the connection. However, the close method cannot actually be called because the emit('close') step can only be executed if this.open is set to true in the source code. In addition, when the called party executes the close method after executing the answer method, the calling party listens to call.on(' close ',()=> {}) cannot respond.
The text was updated successfully, but these errors were encountered: