Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved some files to be 2.0 compatible #1

Closed
wants to merge 2 commits into from
Closed

Moved some files to be 2.0 compatible #1

wants to merge 2 commits into from

Conversation

bjornpost
Copy link

Hi there,

I've updated your Twitter plugin, so it is compatible with the upcoming CakePHP 2.0 release. It mostly involved renaming folders, but I've also updated some App::import() calls.

I've put my changes in a separate branch, since they're not backward compatible with 1.3 and below. But I'm not sure if this pull request puts my changes in a separate branch as well.

Bjorn

@pefringant
Copy link
Owner

You're right, your pull request says "bjornpost wants someone to merge 2 commits into kalt:master from bjornpost:2.0". Do I have to create a new branch myself (sorry, I'm working alone most of the time so I'm not very familiar with git commands other than "add" and "commit") ?

@bjornpost
Copy link
Author

Hmm, I guess you can specify in which branch you want to pull. Can't you change master in something like 2.0? I believe the branch is created if it doesn't exist yet. Just saw that I accidentally removed the Oauth lib. Will add another commit to this request in a few minutes :-). Not true.

Bjorn

@bjornpost bjornpost closed this May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants