Fix a _WrappedScrollBehavior.shouldNotify bug (#103267)

peggyart · May 7, 2022 · 4bed767 · 4bed767
1 parent c6ced84
commit 4bed767
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/flutter/lib/src/widgets/scroll_configuration.dart b/packages/flutter/lib/src/widgets/scroll_configuration.dart
@@ -348,7 +348,7 @@ class _WrappedScrollBehavior implements ScrollBehavior {
         || oldDelegate.overscroll != overscroll
         || oldDelegate.physics != physics
         || oldDelegate.platform != platform
-        || setEquals<PointerDeviceKind>(oldDelegate.dragDevices, dragDevices)
+        || !setEquals<PointerDeviceKind>(oldDelegate.dragDevices, dragDevices)
         || delegate.shouldNotify(oldDelegate.delegate);
   }
 

diff --git a/packages/flutter/test/widgets/scroll_behavior_test.dart b/packages/flutter/test/widgets/scroll_behavior_test.dart
@@ -32,6 +32,14 @@ class TestScrollBehavior extends ScrollBehavior {
 }
 
 void main() {
+  // Regression test for https://github.com/flutter/flutter/issues/89681
+  testWidgets('_WrappedScrollBehavior shouldNotify test', (WidgetTester tester) async {
+    final ScrollBehavior behavior1 = const ScrollBehavior().copyWith();
+    final ScrollBehavior behavior2 = const ScrollBehavior().copyWith();
+
+    expect(behavior1.shouldNotify(behavior2), false);
+  });
+
   testWidgets('Inherited ScrollConfiguration changed', (WidgetTester tester) async {
     final GlobalKey key = GlobalKey(debugLabel: 'scrollable');
     TestScrollBehavior? behavior;