Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tsc for local development instead of webpack #14

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

SrTobi
Copy link
Contributor

@SrTobi SrTobi commented Apr 29, 2021

I'm not sure this solution is really the best, but this PR makes it so that local debug task uses tsc to compile.
Only really drawback is that an out/server.d.ts is created (cannot be turned off because of the composite project).

But I think this is still better then requiring an additional plugin (I think this extension might solve the problem with the webpack watch task).
Also this makes it really fast to edit/start the debug instance.

For deployment webpack can still be used of course.

fixes #13

@hildjj
Copy link
Contributor

hildjj commented Apr 29, 2021

I don't feel strongly about the current dev environment, I just needed to get webpack hacked in so that we were distributing something of reasonable size. I'm going to take this as-is, but feel free to keep sending PRs to tweak things if you come up with better approaches. For example, moving /client and /server to be parallel directories so things are a little easier to find, or whatever.

@hildjj hildjj merged commit 8cbdcfc into peggyjs:main Apr 29, 2021
@hildjj hildjj mentioned this pull request Apr 29, 2021
@SrTobi SrTobi deleted the local-dev branch April 29, 2021 20:47
SrTobi added a commit to SrTobi-Forks/code-peggy-language that referenced this pull request Apr 29, 2021
- have client and server in directory with either name
- main file for the client and server are also called like that
  (at the moment not relevant as we only have one source file each)
- put generated file into out/[client/server]/[client/server].js
- webpack also creates these files but with bundled modules
- this directory structure will also be expected by the client itself

 see peggyjs#14, peggyjs#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficulties using development setup
2 participants