Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example Javascript grammar has inconsistent indentation #445

Closed
frostburn opened this issue Dec 3, 2023 · 2 comments · Fixed by #470
Closed

Example Javascript grammar has inconsistent indentation #445

frostburn opened this issue Dec 3, 2023 · 2 comments · Fixed by #470

Comments

@frostburn
Copy link
Contributor

Most of the lines in the Javascript example seem to be indented with multiples of two spaces, but in the rule for ObjectLiteral there's a line that starts with seven spaces just to give an example of odd indentation:
https://github.com/peggyjs/peggy/blob/main/examples/javascript.pegjs#L543
@hildjj
Copy link
Contributor

hildjj commented Dec 3, 2023

Are you proposing that those lines be out-dented by 1 space? if so, that makes sense to me.

@frostburn
Copy link
Contributor Author

Any direction by 1 space is fine by me. It's just that my code editor was freaking out when I edited those lines for my own variant of the grammar.
Didn't check other lines, but obviously all odd multiples of indenting spaces should be evened out in some direction.

@hildjj hildjj mentioned this issue Jan 28, 2024
Closed
21 tasks
hildjj added a commit to hildjj/peggy that referenced this issue Feb 12, 2024
@hildjj
Fix indentation in one part of examples/javascript.pegjs. Fixes peggy…
4d5918f 
…js#445.
@hildjj hildjj mentioned this issue Feb 12, 2024
Merged
hildjj added a commit to hildjj/peggy that referenced this issue Feb 13, 2024
@hildjj
Merge branch 'main' into stable
c8e31fb 
* main: (107 commits)
  Version update.  Check npmignore.  Audit CHANGELOG.md.
  4.0.0
  Update dependencies final time before release.
  Fix indentation in one part of examples/javascript.pegjs.  Fixes peggyjs#445.
  Code review issues
  Add developer docs.  Fixes peggyjs#466.
  Add directories when they don't exist, rather than throwing an error.  Fixes peggyjs#440.
  Update changelog.  Include peggyjs#463 as well.
  Fix peggyjs#379.  Move reportInfiniteRecursion to prepare phase, ensure that it doesn't keep going when it finds an error.
  Typo: 'rutimes'
  Mark IE as explicitly unsupported
  Switch to flat eslint config.  Lint minified output for web compat.
  Code review nits
  Add tests, fix up fromMem to not need gross hack.
  Adds support for running tests against es module output.  Fixes peggyjs#399.
  Slight wording tweak.  Double-checked that peggyjs#415 is fixed.
  Fixes peggyjs#434
  Update bundles as well
  Fixes peggyjs#450
  Update dependencies, including new lint rules.  Move to simpler tsconfig so that eslint can easily find the correct file.  Fix small lint issues with new rules.
  ...
hildjj added a commit that referenced this issue Feb 13, 2024
@hildjj
Merge branch 'main' into stable
792e1d7 
* main: (107 commits)
  Version update.  Check npmignore.  Audit CHANGELOG.md.
  4.0.0
  Update dependencies final time before release.
  Fix indentation in one part of examples/javascript.pegjs.  Fixes #445.
  Code review issues
  Add developer docs.  Fixes #466.
  Add directories when they don't exist, rather than throwing an error.  Fixes #440.
  Update changelog.  Include #463 as well.
  Fix #379.  Move reportInfiniteRecursion to prepare phase, ensure that it doesn't keep going when it finds an error.
  Typo: 'rutimes'
  Mark IE as explicitly unsupported
  Switch to flat eslint config.  Lint minified output for web compat.
  Code review nits
  Add tests, fix up fromMem to not need gross hack.
  Adds support for running tests against es module output.  Fixes #399.
  Slight wording tweak.  Double-checked that #415 is fixed.
  Fixes #434
  Update bundles as well
  Fixes #450
  Update dependencies, including new lint rules.  Move to simpler tsconfig so that eslint can easily find the correct file.  Fix small lint issues with new rules.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix indentation in one part of examples/javascript.pegjs. hildjj/peggy
2 participants
@hildjj @frostburn