Fix running npm task parser for Windows users
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wait does this work for you? because i did this too, in an older pr that i closed, and after this browserify wasn't willing to roll for me on windows |
|
I'm not sure how browserify would be affected by this. Everything still works fine for me here after applying this change, so I'm going to merge it. @StoneCypher if this breaks you, let me know and we'll figure it out. |
|
Thanks! @StoneCypher, I didn't check browserify tasks, only |
|
Agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix most important part of #94, because without it I can't normally test my changes. Upgrading infrastructure can take some time, so if this will not break linux builds, could it be merged?