Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement offset() and add range() #145

Merged
merged 1 commit into from May 27, 2021
Merged

Reimplement offset() and add range() #145

merged 1 commit into from May 27, 2021

Conversation

Mingun
Copy link
Member

@Mingun Mingun commented May 3, 2021

Backported pegjs/pegjs#528

hildjj
hildjj reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@hildjj hildjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about any of these comments; this is just for discussion.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Mingun Mingun mentioned this pull request May 21, 2021
Merged
@hildjj
Copy link
Contributor

hildjj commented May 22, 2021

Will merge after rebase and update documentation.html. See #152

@hildjj hildjj added this to the 1.2 milestone May 22, 2021
@Mingun
Copy link
Member Author

Mingun commented May 23, 2021

Updated documentation and range() definition. Ready to merge.

@Mingun Mingun requested a review from hildjj May 27, 2021 15:44
@hildjj hildjj merged commit a0e26b4 into peggyjs:main May 27, 2021
@Mingun Mingun deleted the range-offset branch May 27, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hildjj hildjj Awaiting requested review from hildjj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mingun @hildjj @felix9