Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray semicolon in CSS #507

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Conversation

Flamenco
Copy link
Contributor

@Flamenco Flamenco commented Apr 4, 2024

No description provided.

@hildjj
Copy link
Contributor

hildjj commented Apr 4, 2024

Please add a changelog entry and ensure you are in the AUTHORS file. Or, I could do a full pass on the CSS file myself and fix this in the process if you'd prefer.

@Flamenco
Copy link
Contributor Author

Flamenco commented Apr 4, 2024

Oops. Forgot again. I will update. Thanks.

@Flamenco
Copy link
Contributor Author

Flamenco commented Apr 4, 2024

@hildjj I broke up my PR into 3 different ones, so as to not base them off each other. You will have to merge the overlapping CHANGELOG.

CHANGELOG.md Outdated
@@ -11,6 +11,7 @@ Unreleased
### New features

### Bug fixes
- Remove stray semicolon in CSS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to this PR. If you wouldn't mind fixing the one for EOI (#506) at the same time, I'd appreciate it.

@hildjj
Copy link
Contributor

hildjj commented Apr 4, 2024

For the overlapping changelog, I'm going to have you rebase each PR before merging.

@Flamenco
Copy link
Contributor Author

Flamenco commented Apr 4, 2024

So after you approve all 3, I rebase them. Correct?

@hildjj
Copy link
Contributor

hildjj commented Apr 4, 2024

yes. Let's finish the discussion of #509, then tell me what order you want me to apply them.

@hildjj
Copy link
Contributor

hildjj commented Apr 4, 2024

Or if it's easier, just combine them into one PR.

@Flamenco
Copy link
Contributor Author

Flamenco commented Apr 4, 2024

I think keep them separate.

  1. semicolon
  2. enable text
  3. es6 export

@hildjj hildjj merged commit ad40992 into peggyjs:main Apr 4, 2024
9 checks passed
@Flamenco Flamenco deleted the fix_stray_semicolon branch April 5, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants