Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo #70

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ module.exports = {
root: true,
ignorePatterns: [
"docs/",
"lib/parser.js",
"test/vendor/",
"benchmark/vendor/",
"browser/",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Install pnpm
uses: pnpm/action-setup@v1.2.1
with:
version: 5.18.9
version: 5.18.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future i think this should be a matrix build across versions of node and operating systems.

i can show you how to do this if you don't already know; it's easy.

i don't think this PR should block on this, so I opened a new issue about it instead.

run_install: true
- name: Test ${{ matrix.node-version }}
run: npm run test:bare
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
browser/*
examples/*.js
node_modules/
.pnpm-debug.log
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ You can tweak the generated parser with several options:
`peg.generate`
- `--extra-options-file` — file with additional options (in JSON format) to
pass to `peg.generate`
- `--format` — format of the generated parser: `amd`, `commonjs`, `globals`,
- `--format` — format of the generated parser: `amd`, `commonjs`, `es`, `globals`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i request that this say es2015, because there's an older forgotten es4x module format, and because it's likely that es9 or es10 will deliver an incompatible module format that exposes types and directly solves the michael jacksonscript problem

this also leaves it in parity with typescript, rollup, parcel, and rome

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with that. I'd like to document es2015 or whatever we pick, but leave es as an alias, in case anyone started using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use #71 to track this since it's open and it's close enough to this discussion. Please put your comment there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

`umd` (default: `commonjs`)
- `--optimize` — selects between optimizing the generated parser for parsing
speed (`speed`) or code size (`size`) (default: `speed`)
Expand Down
5 changes: 0 additions & 5 deletions benchmark/.eslintrc.json

This file was deleted.

34 changes: 0 additions & 34 deletions benchmark/index.css

This file was deleted.

40 changes: 0 additions & 40 deletions benchmark/index.html

This file was deleted.

138 changes: 0 additions & 138 deletions benchmark/index.js

This file was deleted.

37 changes: 0 additions & 37 deletions benchmark/server

This file was deleted.

22 changes: 0 additions & 22 deletions benchmark/vendor/jquery.scrollto/LICENSE

This file was deleted.

7 changes: 0 additions & 7 deletions benchmark/vendor/jquery.scrollto/jquery.scrollTo.js

This file was deleted.

36 changes: 0 additions & 36 deletions benchmark/vendor/jquery/LICENSE.txt

This file was deleted.

5 changes: 0 additions & 5 deletions benchmark/vendor/jquery/jquery.js

This file was deleted.

Loading