-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo #70
Monorepo #70
Changes from all commits
fb4794a
75e8aa6
3c74d18
e93c9d1
f902906
637cc12
88c22e0
4d0767f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
browser/* | ||
examples/*.js | ||
node_modules/ | ||
.pnpm-debug.log |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,7 +111,7 @@ You can tweak the generated parser with several options: | |
`peg.generate` | ||
- `--extra-options-file` — file with additional options (in JSON format) to | ||
pass to `peg.generate` | ||
- `--format` — format of the generated parser: `amd`, `commonjs`, `globals`, | ||
- `--format` — format of the generated parser: `amd`, `commonjs`, `es`, `globals`, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i request that this say es2015, because there's an older forgotten es4x module format, and because it's likely that es9 or es10 will deliver an incompatible module format that exposes types and directly solves the michael jacksonscript problem this also leaves it in parity with typescript, rollup, parcel, and rome There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm ok with that. I'd like to document There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's use #71 to track this since it's open and it's close enough to this discussion. Please put your comment there? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
`umd` (default: `commonjs`) | ||
- `--optimize` — selects between optimizing the generated parser for parsing | ||
speed (`speed`) or code size (`size`) (default: `speed`) | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future i think this should be a matrix build across versions of node and operating systems.
i can show you how to do this if you don't already know; it's easy.
i don't think this PR should block on this, so I opened a new issue about it instead.