Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Jasmine to Mocha & Chai #409

Closed
dmajda opened this issue Jan 25, 2016 · 0 comments
Closed

Switch from Jasmine to Mocha & Chai #409

dmajda opened this issue Jan 25, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@dmajda
Copy link
Contributor

dmajda commented Jan 25, 2016

Mocha/Chai is a better and more widely used testing tool than Jasmine and it allows for easier extension. Let’s use it instead.

@dmajda dmajda added the task label Jan 25, 2016
@dmajda dmajda added this to the 0.10.0 milestone Jan 25, 2016
@dmajda dmajda modified the milestones: 0.11.0, 0.10.0 Jun 28, 2016
dmajda added a commit that referenced this issue Oct 11, 2016
The core of the transition is getting rid of Makefile and replacing it
with gulpfile.js. The rest is details (fixing dependencies, changing all
references to "make", etc.).

Target/task names mostly stay the same, so in most cases "gulp foo" does
what "make foo" did before. The only exceptions are "make browser" and
"make browserclean", which are now "gulp browser:build" and "gulp
browser:clean" (it feels more systematic).

Functionality is mostly unchanged (modulo Gulp clutter in the console),
but there are two small exceptions:

  gulp spec

    The reporter now displays just dots while previously it displayed
    spec descriptions. There is also a deprecation warning (most likely
    because I used an old version of gulp-jasmine in order to support
    Jasmine 1.x). I kept these issues unfixed because I plan to switch
    to Mocha soon (#409).

  gulp browser:build

    The copyright header is now added manually both to the development
    and minified build. Before, it was added only to the development
    build and the minified build relied on preserving it using "uglify
    --comments". This was broken since switching to //-style comments.

    There is now also an empty line between the header and the source
    code.

Fixes #444.
@dmajda dmajda self-assigned this Oct 11, 2016
@dmajda dmajda changed the title Switch from Jasmine to Mocha/Chai Switch from Jasmine to Mocha & Chai Dec 8, 2016
@dmajda dmajda closed this as completed in 73de2c9 Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant