Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated util.puts and util.error #334

Closed
wants to merge 3 commits into from

Conversation

burningtree
Copy link

In the newest versions of node.js (>0.12) and io.js is util.puts and util.error deprecated. Now, if you use these functions, runtime throw to stdout unnecessary message like util.puts: Use console.log instead.

Reference:
https://nodejs.org/api/util.html#util_util_puts
https://iojs.org/api/util.html#util_util_puts

How to reproduce:

$ node --version
v0.12.2

$ pegjs --version
util.puts: Use console.log instead
PEG.js 0.8.0

This pull request solve this problem. I updated also devDependencies because in older versions of jasmine these functions have also been used.

@burningtree burningtree changed the title Patch 1 Replace deprecated util.puts and util.error. Apr 10, 2015
@burningtree burningtree changed the title Replace deprecated util.puts and util.error. Replace deprecated util.puts and util.error Apr 10, 2015
@dmajda
Copy link
Contributor

dmajda commented Jun 12, 2015

@burningtree Sorry I got to this so late. If you’re still interested, could you please:

  1. Update your devDependencies commit with latest versions of the packages as of now.
  2. Squash the last two commits. (Having a commit history with a commit that breaks formatting and another one that fixes it makes no sense.)
  3. Remove commas at the end of commit messages to fit with the style PEG.js uses.

With these changes I’d be happy to merge.

dmajda added a commit that referenced this pull request Aug 6, 2015
The |util.puts| and |util.error| functions are deprecated in Node.js
0.12.x.

Based on a pull request by Jan Stránský (@burningtree):

  #334
@dmajda
Copy link
Contributor

dmajda commented Aug 6, 2015

No reply, so I replaced the util.puts and util.error calls myself. I’ll update devDependencies just before the 0.9.0 release. Closing.

@dmajda dmajda closed this Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants