-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even more split outs from #339 #345
Conversation
Ok, that should be it for #323 |
Can you please split any changes not directly related to enabling strict mode into separate PR(s)? (Where directly related = without them code doesn’t work properly or JSHint produces errors.) |
Sure, coming right up. |
Ok, updated the branch. |
Thanks for the work, I commented couple of minor issues. |
Thanks for the review. I'll have these issues sorted shortly. Can you see my comment above about the leading |
Should be better now. I left in the |
Looks great, thanks! Merging in a second.
Makes sense to me. |
@arlolra As a side note, I’m on vacation starting tomorrow, so if you come up with more PRs I may react slowly or not at all for the next 2-3 weeks. |
Thanks, and have a nice vacation! I'll probably work on the interruptible parser plugin in the meantime. |
No description provided.