Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"use strict"; #339

Closed
wants to merge 1 commit into from
Closed

"use strict"; #339

wants to merge 1 commit into from

Conversation

arlolra
Copy link
Contributor

@arlolra arlolra commented Jun 4, 2015

 * Issues pegjs#323 and pegjs#324

 * The changes to the tests probably aren't what's desired considering
   what they're trying to test, but, "in strict mode code, functions
   can only be declared at top level or immediately within another
   function.
@dmajda
Copy link
Contributor

dmajda commented Jun 5, 2015

@arlolra Thanks for your contribution. However, it looks like you’re mixing several things in one commit:

Can you please split the PR into one solving #323, one solving #324, and then one for each related set of other changes? This will allow me to review and merge the changes more easily. Also please create a separate commit for each logical change (e.g. in #323 and #324 PRs, there should be a commit for each kind of change that prevents enabling strict mode and then one commit for actually enabling it).

I’d suggest to proceed sequentially and start with #324 because that’s probably the easiest part.

@dmajda dmajda closed this Jun 5, 2015
@arlolra
Copy link
Contributor Author

arlolra commented Jun 5, 2015

Sure, no problem.

dmajda added a commit that referenced this pull request Jun 5, 2015
dmajda added a commit that referenced this pull request Jun 8, 2015
@arlolra arlolra deleted the strict branch June 13, 2015 00:42
dmajda added a commit that referenced this pull request Jun 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants