Point in Polygon related test tweaks 2017-09-26 #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianashk
reviewed
Sep 27, 2017
test_cases/reverse_coarse.json
Outdated
| "region": "Puerto Rico", | ||
| "dependency": "Puerto Rico", | ||
| "country": "United States" |
There was a problem hiding this comment.
removing country here and not replacing it with anything else, like empire, feels a little unsettling
There was a problem hiding this comment.
Yeah agreed. @trescube please opine.
|
looks good to me, I am not adding a review because I'm not sure about the |
orangejulius
force-pushed
the
pip-test-tweaks-2017-09-26
branch
from
efbd87a
to
e40a3e1
Compare
This likely changed due to differences in admin lookup strategies
|
Ok this has all been updated and the Puerto Rico case is no longer being handled here. See #437 for the handling of that issue. |
dianashk
approved these changes
Sep 28, 2017
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our acceptance tests for PIP related changes.
There is one case of a previously working test failing because the new admin lookup strategy has exposed a broken WOF hierarchy, as well as some name changes. One other test is changed to reflect an updated hierarchy, which may have also been because of our admin lookup changes.