New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added postalcode rules for node-postal call and fallbacks #974

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
2 participants
@rabidllama
Contributor

rabidllama commented Sep 5, 2017

Updated searching to take into account postcodes in structured search and to use the fallback scoring if postcode is passed with a country.

In relation to issue #973

@wafflebot wafflebot bot added the in review label Sep 5, 2017

@dianashk

Thank you so much for your contribution ! We really appreciate it. ❤️

This looks great! I tested it locally and it seems to work as advertised. 👏 🌮

It would be really helpful if you could add one or two tests to show the intention behind the new code. We already have a test file for these modules so hopefully, there are existing tests that can be borrowed from.

Let us know if you don't have the bandwidth to get to those and we'll take care of adding them on our own once this is merged.

Thank you, again, for your contribution!

@rabidllama

This comment has been minimized.

Show comment
Hide comment
@rabidllama

rabidllama Sep 12, 2017

Contributor

Just added some tests (and added a couple of postcode parameters to some other tests) which hopefully will cover it :)

Contributor

rabidllama commented Sep 12, 2017

Just added some tests (and added a couple of postcode parameters to some other tests) which hopefully will cover it :)

@dianashk

Thank you for adding the tests! This looks great and works well. 🎉

@dianashk dianashk merged commit c06607a into pelias:master Sep 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment