Add countryCode property to WOF configuration
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the Who's on First downloader defaults to using SQLite downloads and supports country-specific bundles thanks to pelias/whosonfirst#487, we can start using that new functionality. This PR sets the `imports.whosonfirst.countryCode` property appropriately across all our current projects. This should not only help make all imports quite a bit faster, but it will require much less disk space for everyone. Since we're now sponsoring the Who's on First downloads here at Geocode Earth, the bandwidth savings also make us happy :) Along the way I made a few minor changes to remove some deprecated config options like `importVenues` and `sqlite`.
calpb
pushed a commit
to sorelle/docker
that referenced
this pull request
Mar 29, 2021
Add `countryCode` property to WOF configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the Who's on First downloader defaults to using SQLite downloads and supports country-specific bundles thanks to pelias/whosonfirst#487, we can start using that new functionality.
This PR sets the
imports.whosonfirst.countryCodeproperty appropriately across all our current projects.This should not only help make all imports quite a bit faster, but it will require much less disk space for everyone!
Since we're now sponsoring the Who's on First downloads here at Geocode Earth, the bandwidth savings also make us happy :)
Along the way I made a few minor changes to remove some deprecated config options like
importVenuesandsqlite.