a set of generators & test cases for major POIs generated from wikipedia #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once again, these are awesome. I thought of the existing scripts in |
Comment on lines
22
to
32
| "expected": { | ||
| "coordinates": [ | ||
| -96.34028, | ||
| 30.61 | ||
| ], | ||
| "distanceThresh": 5000, | ||
| "properties": { | ||
| "layer": "venue" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
We will probably want an expected name field. Right now all these tests will pass as long as any venue within 5km of the given point is returned. While that's nice for getting around minor name differences it's probably too lenient :(
|
poke |
|
lmk if you want to land this? |
|
@orangejulius lmk if you want to land this or I can close. Trying to clean up my backlog of open / unfinished tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is partly here as a PoC
I'm curious if you'd want me to integrate it into the scripts in fuzzy-tester. It seems like it's different enough (doesn't use csvs as input) and relies on a bunch of libraries that I'm not sure if it should be integrated into that existing flow. I'm happy to make it work better with that though.
I was curious to see how we're doing on standalone major POIs so ... I built this. It mostly works. wikipedia is a pain.