rename 'polygon' field to 'shape' to match pelias/schema

[missinglink]

The setPolygon() and getPolygon() methods are replaced by setShape() & getShape().

This ensures the field and method names are consistent with Pelias Schema.

As discussed in pelias/schema#466 the field name should be shape, not polygon.

It's astounding that it's gone 3 years without anyone noticing that it didn't actually work, most likely because it's not very often used.

[orangejulius]

Yeah, to be clear, outside of little bits of testing out functionality for importing geometries (as part of pelias/whosonfirst#19, pelias/api#1121, etc), this method has never been used.

In the past, we've had a lot of problems with importing geometries into Elasticsearch (poor performance, rejection of large geometries like that of New Zealand by Elasticsearch), but at least theoretically we should allow it. Either that or we should delete the shape field from the schema all together and tell people to use the Spatial service.

[missinglink]

Agh ok, so I'm also not against removing the field instead.

[Joxit]

I am OK with the removing or renaming of the field. 👍

Both solutions will create a breaking change...

[orangejulius]

Can't believe we had this bug for 3+ years :)

I'm skeptical Elasticsearch geo_shape fields will ever be performant enough to use, but lets merge this for now and try it out. If not we'll remove the field and go 100% all in on the Spatial service :)