perf improvement for "verbose" PIP query #67
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since #65 landed and the dist files have been (at least partially?) updated, we can now simplify the 'verbose PIP' query π
I've also taken the opportunity to rename a couple of the variables to be more readable.
I ran the query for lat/lon NYC on a full-planet database before and after this change (just via the CLI with no
mmap
) and the difference was considerable:before:
5.481ms
vs after:0.228ms
cc @Joxit
I should probably purge the CDN cache for spatial so that all the files get regenerated with #65 before I merge this π€·ββοΈactually no need, this will happen naturally and isn't required to merge this.