update generic name & abbreviation to be compatible with wof-admin-lookup #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was comparing the output of PIP results for
wof-admin-lookupvsspatialand noticed that the abbreviations were different.So I've ported the old logic from
wof-admin-lookupin order to select the same fields.It's actually a bit of a mess and took me a while to dig around the repos trying to figure out what's correct, there are some bits which are unusual, like using the
qs:a2_altfield 🤷In the end I chose to honour what we were doing in
wof-admin-lookupand we can worry about whether or not that is 'correct' later 😆